@@ -21,6 +21,7 @@ package status_test
2121import (
2222 "context"
2323 "errors"
24+ "reflect"
2425 "strings"
2526 "testing"
2627 "time"
@@ -35,8 +36,10 @@ import (
3536 "google.golang.org/grpc/status"
3637 "google.golang.org/protobuf/proto"
3738 "google.golang.org/protobuf/protoadapt"
39+ "google.golang.org/protobuf/testing/protocmp"
3840
3941 testpb "google.golang.org/grpc/interop/grpc_testing"
42+ tpb "google.golang.org/grpc/testdata/grpc_testing_not_regenerated"
4043)
4144
4245const defaultTestTimeout = 10 * time .Second
@@ -203,3 +206,56 @@ func (s) TestStatusDetails(t *testing.T) {
203206 })
204207 }
205208}
209+
210+ // TestStatus_ErrorDetailsMessageV1 verifies backward compatibility of the
211+ // status.Details() method when using protobuf code generated with only the
212+ // MessageV1 API implementation.
213+ func (s ) TestStatus_ErrorDetailsMessageV1 (t * testing.T ) {
214+ details := []protoadapt.MessageV1 {
215+ & tpb.SimpleMessage {Data : "abc" },
216+ }
217+ s , err := status .New (codes .Aborted , "" ).WithDetails (details ... )
218+ if err != nil {
219+ t .Fatalf ("(%v).WithDetails(%+v) failed: %v" , s , details , err )
220+ }
221+ gotDetails := s .Details ()
222+ for i , msg := range gotDetails {
223+ if got , want := reflect .TypeOf (msg ), reflect .TypeOf (details [i ]); got != want {
224+ t .Errorf ("reflect.Typeof(%v) = %v, want = %v" , msg , got , want )
225+ }
226+ if _ , ok := msg .(protoadapt.MessageV1 ); ! ok {
227+ t .Errorf ("(%v).Details() returned message that doesn't implement protoadapt.MessageV1: %v" , s , msg )
228+ }
229+ if diff := cmp .Diff (msg , details [i ], protocmp .Transform ()); diff != "" {
230+ t .Errorf ("(%v).Details got unexpected output, diff (-got +want):\n %s" , s , diff )
231+ }
232+ }
233+ }
234+
235+ // TestStatus_ErrorDetailsMessageV1AndV2 verifies that status.Details() method
236+ // returns the same message types when using protobuf code generated with both the
237+ // MessageV1 and MessageV2 API implementations.
238+ func (s ) TestStatus_ErrorDetailsMessageV1AndV2 (t * testing.T ) {
239+ details := []protoadapt.MessageV1 {
240+ & testpb.Empty {},
241+ }
242+ s , err := status .New (codes .Aborted , "" ).WithDetails (details ... )
243+ if err != nil {
244+ t .Fatalf ("(%v).WithDetails(%+v) failed: %v" , s , details , err )
245+ }
246+ gotDetails := s .Details ()
247+ for i , msg := range gotDetails {
248+ if got , want := reflect .TypeOf (msg ), reflect .TypeOf (details [i ]); got != want {
249+ t .Errorf ("reflect.Typeof(%v) = %v, want = %v" , msg , got , want )
250+ }
251+ if _ , ok := msg .(protoadapt.MessageV1 ); ! ok {
252+ t .Errorf ("(%v).Details() returned message that doesn't implement protoadapt.MessageV1: %v" , s , msg )
253+ }
254+ if _ , ok := msg .(protoadapt.MessageV2 ); ! ok {
255+ t .Errorf ("(%v).Details() returned message that doesn't implement protoadapt.MessageV2: %v" , s , msg )
256+ }
257+ if diff := cmp .Diff (msg , details [i ], protocmp .Transform ()); diff != "" {
258+ t .Errorf ("(%v).Details got unexpected output, diff (-got +want):\n %s" , s , diff )
259+ }
260+ }
261+ }
0 commit comments