fix: check existence for 'create-plugin'

Author: xavier-hou

cmd/devstream/list/list.go

@@ -21,3 +21,23 @@ func List() {
 		fmt.Println(pluginName)
 	}
 }
+
+// Get plugins name in slice
+func PluginsNameSlice() []string {
+	listPluginsName := strings.Fields(PluginsName)
+	sort.Strings(listPluginsName)
+	return listPluginsName
+}
+
+// Get plugins name in map
+func PluginNamesMap() map[string]struct{} {
+	mp := make(map[string]struct{})
+
+	listPluginsName := strings.Fields(PluginsName)
+
+	for _, pluginName := range listPluginsName {
+		mp[pluginName] = struct{}{}
+	}
+
+	return mp
+}

internal/pkg/develop/plugin/create.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/spf13/viper"
 
+	"github.com/devstream-io/devstream/cmd/devstream/list"
 	"github.com/devstream-io/devstream/pkg/util/log"
 )
 
@@ -19,6 +20,11 @@ func Create() error {
 	}
 	log.Debugf("Got the name: %s.", name)
 
+	if pluginExists(name) {
+		return fmt.Errorf("Plugin name: %s is already exists", name)
+	}
+	log.Debugf("Got the name: %s.", name)
+
 	p := NewPlugin(name)
 
 	// 1. Render template files
@@ -40,3 +46,14 @@ func Create() error {
 
 	return nil
 }
+
+// Check whether the new name exists.
+func pluginExists(name string) bool {
+	pluginMp := list.PluginNamesMap()
+
+	if _, ok := (pluginMp)[name]; ok {
+		return true
+	}
+
+	return false
+}

internal/pkg/develop/plugin/validate.go

@@ -2,8 +2,6 @@ package plugin
 
 import (
 	"fmt"
-	"sort"
-	"strings"
 
 	"github.com/spf13/viper"
 
@@ -31,8 +29,7 @@ func Validate() error {
 // Validate all plugins
 // calling ValidatePlugin() via all plugins name
 func ValidatePlugins() error {
-	listPluginsName := strings.Fields(list.PluginsName)
-	sort.Strings(listPluginsName)
+	listPluginsName := list.PluginsNameSlice()
 
 	for _, pluginName := range listPluginsName {
 		log.Infof("===== start validating <%s> =====", pluginName)