Skip to content

Commit c0d87c1

Browse files
committed
mongoose 3.x and other fixes to test suite.
1 parent 4c0b998 commit c0d87c1

File tree

3 files changed

+21
-17
lines changed

3 files changed

+21
-17
lines changed

tests/email.test.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
require('should');
1+
var should = require('should');
22
var mongoose = require('mongoose')
33
, Schema = mongoose.Schema
4+
, SchemaTypes = mongoose.SchemaTypes || mongoose.Schema.Types
45
, db = mongoose.createConnection('mongodb://localhost/mongoose_types_tests');
56

67
require("../").loadTypes(mongoose, 'email');
78

89
var UserSchema = new Schema({
9-
email: mongoose.SchemaTypes.Email
10+
email: SchemaTypes.Email
1011
});
1112

1213
mongoose.model('User', UserSchema);
@@ -20,14 +21,15 @@ module.exports = {
2021
'test invalid email validation': function () {
2122
var user = new User({email: 'hello'});
2223
user.save(function (err) {
23-
err.message.should.equal('Validator "email is invalid" failed for path email');
24+
var message = err.errors.email.message || err.message;
25+
message.should.equal('Validator "email is invalid" failed for path email');
2426
user.isNew.should.be.true;
2527
});
2628
},
2729
'test valid email validation': function () {
2830
var user = new User({ email: '[email protected]' });
2931
user.save(function (err) {
30-
err.should.eql(null);
32+
should.not.exist(err);
3133
user.isNew.should.be.false;
3234
});
3335
},

tests/url.test.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
require('should');
1+
var should = require('should');
22
var mongoose = require('mongoose')
33
, Schema = mongoose.Schema
4+
, SchemaTypes = mongoose.SchemaTypes || mongoose.Schema.Types
45
, db = mongoose.createConnection('mongodb://localhost/mongoose_types_tests');
56

67
require("../").loadTypes(mongoose, 'url');
78

89
var WebpageSchema = new Schema({
9-
url: mongoose.SchemaTypes.Url
10+
url: SchemaTypes.Url
1011
});
1112

1213
mongoose.model('Webpage', WebpageSchema);
@@ -20,14 +21,15 @@ module.exports = {
2021
'test invalid url validation': function () {
2122
var webpage = new Webpage({url: 'file:///home/'});
2223
webpage.save(function (err) {
23-
err.message.should.equal('Validator "url is invalid" failed for path url');
24+
var message = err.errors.url.message || err.message;
25+
message.should.equal('Validator "url is invalid" failed for path url');
2426
webpage.isNew.should.be.true;
2527
});
2628
},
2729
'test valid url validation': function () {
2830
var webpage = new Webpage({ url: 'http://www.google.com/' });
2931
webpage.save(function (err) {
30-
err.should.eql(null);
32+
should.not.exist(err);
3133
webpage.isNew.should.be.false;
3234
});
3335
},

tests/useTimestamps.test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require('should');
1+
var should = require('should');
22
var mongoose = require('mongoose')
33
, Schema = mongoose.Schema
44
, db = mongoose.createConnection('mongodb://localhost/mongoose_types_tests')
@@ -17,25 +17,25 @@ module.exports = {
1717
before: function(done){
1818
TimeCop = db.model('TimeCop', TimeCopSchema);
1919
TimeCop.remove({}, function () {
20-
done();
20+
//done();
2121
});
2222
},
23-
'createdAt and updatedAt should be set to the same value on creation': function (done) {
23+
'createdAt and updatedAt should be set to the same value on creation': function (done, assert) {
2424
var cop = new TimeCop({ email: '[email protected]' });
2525
cop.save( function (err) {
26-
cop.createdAt.should.be.an.instanceof(Date);
27-
cop.updatedAt.should.be.an.instanceof(Date);
28-
done();
26+
(cop.createdAt instanceof Date).should.be.true;
27+
(cop.updatedAt instanceof Date).should.be.true;
28+
//done();
2929
});
3030
},
31-
'updatedAt should be later than createdAt upon updating': function (done) {
31+
'updatedAt should be later than createdAt upon updating': function (done, assert) {
3232
TimeCop.findOne({email: '[email protected]'}, function (err, found) {
3333
found.email = '[email protected]';
3434
setTimeout( function () {
3535
found.save( function (err, updated) {
36-
updated.updatedAt.should.be.greater.than(updated.createdAt);
36+
updated.updatedAt.should.be.above(updated.createdAt);
3737
assert.ok(updated.updatedAt > updated.createdAt);
38-
done();
38+
//done();
3939
});
4040
}, 1000);
4141
});

0 commit comments

Comments
 (0)