fix: removed braces for alias (#52)

* removed braces for alias

* updated test cases

* bumped up package.json versions

Author: zaidjan-devrev

meerkat-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/meerkat-core",
-  "version": "0.0.60",
+  "version": "0.0.61",
   "dependencies": {
     "@swc/helpers": "~0.5.0"
   },

meerkat-core/src/cube-measure-transformer/cube-measure-transformer.spec.ts

@@ -31,13 +31,13 @@ describe('cubeMeasureToSQLSelectString', () => {
   it('should construct a SQL select string with COUNT(*) when provided with correct measure', () => {
     const measures: Member[] = ['temp.measure1'];
     const result = cubeMeasureToSQLSelectString(measures, tableSchema);
-    expect(result).toBe(`SELECT (COUNT(*)) AS temp__measure1 `);
+    expect(result).toBe(`SELECT COUNT(*) AS temp__measure1 `);
   });
 
   it('should construct a SQL select string with SUM(total) when provided with correct measure', () => {
     const measures: Member[] = ['temp.measure2'];
     const result = cubeMeasureToSQLSelectString(measures, tableSchema);
-    expect(result).toBe(`SELECT (SUM(total)) AS temp__measure2 `);
+    expect(result).toBe(`SELECT SUM(total) AS temp__measure2 `);
   });
 
   it('should substitute "*" for all columns in the cube', () => {
@@ -56,7 +56,7 @@ describe('cubeMeasureToSQLSelectString', () => {
       sqlToReplace
     );
     expect(result).toBe(
-      `SELECT (COUNT(*)) AS temp__measure1 , (SUM(total)) AS temp__measure2  FROM my_table`
+      `SELECT COUNT(*) AS temp__measure1 , SUM(total) AS temp__measure2  FROM my_table`
     );
   });
 
@@ -70,7 +70,7 @@ describe('cubeMeasureToSQLSelectString', () => {
       sqlToReplace
     );
     expect(result).toBe(
-      `SELECT (COUNT(*)) AS temp__measure1 , (SUM(total)) AS temp__measure2  FROM (SELECT * FROM TABLE_1)`
+      `SELECT COUNT(*) AS temp__measure1 , SUM(total) AS temp__measure2  FROM (SELECT * FROM TABLE_1)`
     );
   });
 
@@ -85,7 +85,7 @@ describe('cubeMeasureToSQLSelectString', () => {
       sqlToReplace
     );
     expect(result).toBe(
-      `SELECT (COUNT(*)) AS temp__measure1 , (SUM(total)) AS temp__measure2 ,   (dimension1) AS temp__dimension1,  (DATE_TRUNC('month', order_date)) AS temp__dimension2 FROM (SELECT * FROM TABLE_1)`
+      `SELECT COUNT(*) AS temp__measure1 , SUM(total) AS temp__measure2 ,   dimension1 AS temp__dimension1,  DATE_TRUNC('month', order_date) AS temp__dimension2 FROM (SELECT * FROM TABLE_1)`
     );
   });
 });

meerkat-core/src/cube-measure-transformer/cube-measure-transformer.ts

@@ -24,7 +24,7 @@ export const cubeMeasureToSQLSelectString = (
     if (i > 0) {
       base += ',';
     }
-    base += ` (${measureSchema.sql}) AS ${aliasKey} `;
+      base += ` ${measureSchema.sql} AS ${aliasKey} `;
   }
   return base;
 };
@@ -52,7 +52,7 @@ const addDimensionToSQLProjection = (
     if (i > 0) {
       newSelectString += ',';
     }
-    newSelectString += `  (${dimensionSchema.sql}) AS ${aliasKey}`;
+    newSelectString += `  ${dimensionSchema.sql} AS ${aliasKey}`;
   }
   return newSelectString;
 };

meerkat-node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/meerkat-node",
-  "version": "0.0.61",
+  "version": "0.0.62",
   "dependencies": {
     "@swc/helpers": "~0.5.0",
     "@devrev/meerkat-core": "*",

meerkat-node/src/__tests__/test-data.ts

@@ -70,7 +70,7 @@ export const TABLE_SCHEMA = {
 export const TEST_DATA = [
   {
     testName: 'GroupBySQLInnerQuery',
-    expectedSQL: `SELECT (SUM(order_amount)) AS orders__total_order_amount ,   (DATE_TRUNC('month', order_date)) AS orders__order_month FROM (select * from orders) AS orders GROUP BY orders__order_month LIMIT 1`,
+    expectedSQL: `SELECT SUM(order_amount) AS orders__total_order_amount ,   DATE_TRUNC('month', order_date) AS orders__order_month FROM (select * from orders) AS orders GROUP BY orders__order_month LIMIT 1`,
     cubeInput: {
       measures: ['orders.total_order_amount'],
       filters: [],
@@ -86,7 +86,7 @@ export const TEST_DATA = [
   },
   {
     testName: 'GroupBy',
-    expectedSQL: `SELECT (SUM(order_amount)) AS orders__total_order_amount ,   (customer_id) AS orders__customer_id FROM (select * from orders) AS orders GROUP BY orders__customer_id`,
+    expectedSQL: `SELECT SUM(order_amount) AS orders__total_order_amount ,   customer_id AS orders__customer_id FROM (select * from orders) AS orders GROUP BY orders__customer_id`,
     cubeInput: {
       measures: ['orders.total_order_amount'],
       filters: [],