Skip to content

Commit f4a4265

Browse files
author
Hugo Rialan
authored
Merge pull request #6 from tanukifk/sandbox
specify a time zone in CURRENT_DATE() in data_freshness_assertion
2 parents 7a9b9bd + f0c4c04 commit f4a4265

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

definitions/example.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,13 @@ const commonAssertionsResult = commonAssertions({
2929
"dateColumn": "updated_date",
3030
"timeUnit": "DAY",
3131
"delayCondition": 1,
32+
"timeZone": "America/Los_Angeles"
3233
},
3334
"second_table": {
3435
"dateColumn": "updated_date",
3536
"timeUnit": "MONTH",
3637
"delayCondition": 3,
38+
"timeZone": "-08"
3739
}
3840
},
3941
dataCompletenessConditions: {

includes/data_freshness_assertions.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
const assertions = [];
1919

20-
const createDataFreshnessAssertion = (globalParams, tableName, delayCondition, timeUnit, dateColumn) => {
20+
const createDataFreshnessAssertion = (globalParams, tableName, delayCondition, timeUnit, dateColumn, timeZone = "UTC") => {
2121
const assertion = assert(`assert_freshness_${tableName}`)
2222
.database(globalParams.database)
2323
.schema(globalParams.schema)
@@ -27,7 +27,7 @@ const createDataFreshnessAssertion = (globalParams, tableName, delayCondition, t
2727
WITH
2828
freshness AS (
2929
SELECT
30-
DATE_DIFF(CURRENT_DATE(), MAX(${dateColumn}), ${timeUnit}) AS delay
30+
DATE_DIFF(CURRENT_DATE("${timeZone}"), MAX(${dateColumn}), ${timeUnit}) AS delay
3131
FROM
3232
${ctx.ref(tableName)}
3333
)
@@ -53,9 +53,10 @@ module.exports = (globalParams, freshnessConditions) => {
5353
const {
5454
delayCondition,
5555
timeUnit,
56-
dateColumn
56+
dateColumn,
57+
timeZone
5758
} = freshnessConditions[tableName];
58-
createDataFreshnessAssertion(globalParams, tableName, delayCondition, timeUnit, dateColumn);
59+
createDataFreshnessAssertion(globalParams, tableName, delayCondition, timeUnit, dateColumn, timeZone);
5960
}
6061

6162
return assertions;

0 commit comments

Comments
 (0)