Merge pull request #9 from devoteamgcloud/fix-timestamp

Fix timestamp issue

Author: Hugo Rialan

definitions/example.js

@@ -32,8 +32,11 @@ const commonAssertionsResult = commonAssertions({
       "timeZone": "America/Los_Angeles"
     },
     "second_table": {
-      "dateColumn": "updated_date",
-      "timeUnit": "MONTH",
+      // If timeUnit is not DAY, WEEK, MONTH, QUARTER, or YEAR, dateColumn should be a TIMESTAMP.
+      // Check here for valid Date time units: https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#date_diff
+      // Check here for valid Timestamp time units: https://cloud.google.com/bigquery/docs/reference/standard-sql/timestamp_functions#timestamp_diff
+      "dateColumn": "TIMESTAMP(updated_date)",
+      "timeUnit": "HOUR",
       "delayCondition": 3,
       "timeZone": "-08"
     }

includes/data_freshness_assertions.js

@@ -27,7 +27,9 @@ const createDataFreshnessAssertion = (globalParams, tableName, delayCondition, t
                 WITH
                     freshness AS (
                         SELECT
-                            DATE_DIFF(CURRENT_TIMESTAMP("${timeZone}"), MAX(${dateColumn}), ${timeUnit}) AS delay
+                          ${["DAY", "WEEK", "MONTH", "QUARTER", "YEAR"].includes(timeUnit)
+                              ? `DATE_DIFF(CURRENT_DATE("${timeZone}"), MAX(${dateColumn}), ${timeUnit})`
+                              : `TIMESTAMP_DIFF(CURRENT_TIMESTAMP(), MAX(${dateColumn}), ${timeUnit})`} AS delay
                         FROM
                             ${ctx.ref(tableName)}
                     )