Skip to content

Commit 1110865

Browse files
committed
fixup! fixup! fixup! fixup! fixup! fixes
Signed-off-by: Oleksii Kurinnyi <[email protected]>
1 parent 686e07b commit 1110865

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

test/e2e/pkg/tests/custom_init_container_tests.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ var _ = ginkgo.Describe("[Custom Init Container Tests]", func() {
5757

5858
ginkgo.BeforeEach(func() {
5959
dwocFile := filepath.Join(getProjectRoot(), "test", "resources", "dwoc-custom-init.yaml")
60-
cmd := exec.Command("kubectl", "apply", "-f", dwocFile)
60+
cmd := exec.Command("kubectl", "apply", "-f", dwocFile, "-n", config.OperatorNamespace)
6161
output, err := cmd.CombinedOutput()
6262
if err != nil {
63-
ginkgo.Fail(fmt.Sprintf("Failed to apply DWOC: %s. Output: %s", err, string(output)))
63+
ginkgo.Fail(fmt.Sprintf("Failed to apply DWOC to namespace %s: %s. Output: %s", config.OperatorNamespace, err, string(output)))
6464
}
6565
})
6666

@@ -78,7 +78,7 @@ var _ = ginkgo.Describe("[Custom Init Container Tests]", func() {
7878
ginkgo.Fail(fmt.Sprintf("Workspace didn't start properly. Error: %s", err))
7979
}
8080

81-
// Wait for pod to be running (may take a while for large image pulls)
81+
// Wait for pod to be running
8282
podSelector := fmt.Sprintf("controller.devfile.io/devworkspace_name=%s", workspaceName)
8383
var podName string
8484
gomega.Eventually(func() error {
@@ -105,10 +105,10 @@ var _ = ginkgo.Describe("[Custom Init Container Tests]", func() {
105105

106106
ginkgo.BeforeEach(func() {
107107
dwocFile := filepath.Join(getProjectRoot(), "test", "resources", "dwoc-disabled-init.yaml")
108-
cmd := exec.Command("kubectl", "apply", "-f", dwocFile)
108+
cmd := exec.Command("kubectl", "apply", "-f", dwocFile, "-n", config.OperatorNamespace)
109109
output, err := cmd.CombinedOutput()
110110
if err != nil {
111-
ginkgo.Fail(fmt.Sprintf("Failed to apply DWOC: %s. Output: %s", err, string(output)))
111+
ginkgo.Fail(fmt.Sprintf("Failed to apply DWOC to namespace %s: %s. Output: %s", config.OperatorNamespace, err, string(output)))
112112
}
113113
})
114114

test/resources/dwoc-custom-init.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ apiVersion: controller.devfile.io/v1alpha1
22
kind: DevWorkspaceOperatorConfig
33
metadata:
44
name: devworkspace-operator-config
5-
namespace: openshift-operators
65
config:
76
workspace:
87
initContainers:

test/resources/dwoc-disabled-init.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ apiVersion: controller.devfile.io/v1alpha1
22
kind: DevWorkspaceOperatorConfig
33
metadata:
44
name: devworkspace-operator-config
5-
namespace: openshift-operators
65
config:
76
workspace:
87
persistUserHome:

0 commit comments

Comments
 (0)