Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COEFF: track PCA/NMF vs. Archetypes vs. Legendre separately #274

Open
sbailey opened this issue Jan 26, 2024 · 0 comments
Open

COEFF: track PCA/NMF vs. Archetypes vs. Legendre separately #274

sbailey opened this issue Jan 26, 2024 · 0 comments
Assignees
Labels

Comments

@sbailey
Copy link
Collaborator

sbailey commented Jan 26, 2024

Currently the Redrock output COEFF column can mean different things:

  • in default mode it is the PCA/NMF template coefficients
  • in archetype mode, it is the archetype coefficients, and the PCA/NMF coefficients are lost
  • in archetype+legendre mode some coefficients are archetype coeffs and others are legendre coeffs
    • I'm not even sure if you can tell from the output file whether it used 1+3*n archetypes, or 1 archetype with 3 cameras * n legendre coefficients.

I suggest that we track these separately with something like:

  • COEFF is always coefficients from original PCA/NMF scan
  • ARCHCOEFF (or some similar name) are optional Archetype coefficients
  • LEGCOEFF are optional Legendre coefficients
    • TBD: or maybe LEGCOEFF if those apply to COEFF, and ARCHLEGCOEFF if they apply to Archetypes?
    • TBD: for LEGCOEFF[i] as the coefficients for target i:
      • if this is 1D[n], it means they are n polynomials cross-camera (like the templates);
      • if this is 2D[m,n], it means they are for m cameras and n polynomials.

@abhi0395 let's discuss and refine. Comments / ideas from others are welcome too.

@sbailey sbailey added this to Jura Jan 26, 2024
@sbailey sbailey moved this to In Progress in Jura Feb 6, 2024
@sbailey sbailey moved this from In Progress to Todo in Jura Feb 6, 2024
@sbailey sbailey removed the status in Jura Mar 15, 2024
@sbailey sbailey removed this from Jura Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants