You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we want to test using desimeter transforms (alternate to platemaker) on the instrument, I think the easiest thing might be to run an "xy test" with a few suggested modifications, described below. Nothing is easy, exactly, but I guess this is least pain. The system is pretty intricate --- I'm sure we'd want Duan or Kevin to do this. Anyway I took a pass through the code and think these are the changes needed. All code links below are at current revisions as of writing.
Or perhaps David R could give us some code to more directly set up the FVC.
Line 182: make a conditional like if fvc == 'desimeter':
Put in code here that triggers an exposure, sends the FITS file to desimeter.fvc2fp() function, gets back QS values, and then shoehorns them into format that the "meapos" dataframe is supposed to contain. (Who here wishes we were running in a properly typed language... raise your hands! I don't have the heart to trace down how meapos is structured at the moment.)
Device location ids are encoded mixed with coordinate system.
Better format would have headers:
TARGET_NUMBER
PETAL_LOC
DEVICE_LOC
uv_type
u
v
For example with 10 petals, ~500 positioners / petal, and 10 test targets, the csv file would have 50,000 rows.
You could break this up into smaller files by petal, or smaller files by target number. Seems pointless to me, but you could do that. I prefer one file == one test. If you do break it up into smaller files, you need to change how these are stated in the config file.
For description of valid uv_type for move requests, please see posschedule.py.
request_target() function, comments in lines 42-53.
valid options would be: 'platemaker' or 'desimeter'
or perhaps could add further suboptions if you want to try different flavors of desimeter, like maybe 'desimeter_7paramfit' vs 'desimeter_42paramfit'. Whatever.
Fill in all petals to be tested, like ['01'], ['02], etc
mode = 'all' --> will test all positioners on that petal with CTRL_ENABLED
alternately to test only a specific list of positioners...
I think this should be eliminated and just use coordinate system specified in the uv_type of input file. It's redundant and just one more setting to get wrong at time of test.
num_corr_max --> probably set this to 3 for purposes of test
targ_max_radius --> set to None for clarity (it will be ignored, since using csv of targets)
targ_min_radius --> set to None for clarity (it will be ignored, since using csv of targets)
pause_interval --> I'm not sure what our latest info on cooling is, but 590 sec is the nominal design limit. We can probably go a bit faster.
The text was updated successfully, but these errors were encountered:
If we want to test using desimeter transforms (alternate to platemaker) on the instrument, I think the easiest thing might be to run an "xy test" with a few suggested modifications, described below. Nothing is easy, exactly, but I guess this is least pain. The system is pretty intricate --- I'm sure we'd want Duan or Kevin to do this. Anyway I took a pass through the code and think these are the changes needed. All code links below are at current revisions as of writing.
pecs.py
if fvc == 'desimeter':
if fvc == 'desimeter':
xytest.py
Input targets file
Test settings config file
The text was updated successfully, but these errors were encountered: