Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run an xytest using desimeter #18

Open
joesilber opened this issue Jan 7, 2020 · 0 comments
Open

How to run an xytest using desimeter #18

joesilber opened this issue Jan 7, 2020 · 0 comments

Comments

@joesilber
Copy link
Contributor

joesilber commented Jan 7, 2020

If we want to test using desimeter transforms (alternate to platemaker) on the instrument, I think the easiest thing might be to run an "xy test" with a few suggested modifications, described below. Nothing is easy, exactly, but I guess this is least pain. The system is pretty intricate --- I'm sure we'd want Duan or Kevin to do this. Anyway I took a pass through the code and think these are the changes needed. All code links below are at current revisions as of writing.

pecs.py

xytest.py

Input targets file

  • The current format is kind of awkward.
  • Better format would have headers:
    • TARGET_NUMBER
    • PETAL_LOC
    • DEVICE_LOC
    • uv_type
    • u
    • v
    • For example with 10 petals, ~500 positioners / petal, and 10 test targets, the csv file would have 50,000 rows.
      • You could break this up into smaller files by petal, or smaller files by target number. Seems pointless to me, but you could do that. I prefer one file == one test. If you do break it up into smaller files, you need to change how these are stated in the config file.
    • For description of valid uv_type for move requests, please see posschedule.py.
  • Easiest place to put the targets csv is the same folder as the xytest config file, i.e. code/focalplane

Test settings config file

  • Based off of template: https://desi.lbl.gov/trac/browser/code/focalplane/fp_settings/test_settings/xytest_template.cfg?rev=129521
  • We should add a parameter:
    • fvc2fp_mode
    • valid options would be: 'platemaker' or 'desimeter'
    • or perhaps could add further suboptions if you want to try different flavors of desimeter, like maybe 'desimeter_7paramfit' vs 'desimeter_42paramfit'. Whatever.
  • Fill in all petals to be tested, like ['01'], ['02], etc
    • mode = 'all' --> will test all positioners on that petal with CTRL_ENABLED
    • alternately to test only a specific list of positioners...
      • mode = 'can'
      • posids = [posid_str1, posid_str2, posid_str3, ...]
  • input_targs_file = path to your csv
    • this may require some adjustment (see above)
  • target_type
    • I think this should be eliminated and just use coordinate system specified in the uv_type of input file. It's redundant and just one more setting to get wrong at time of test.
  • num_corr_max --> probably set this to 3 for purposes of test
  • targ_max_radius --> set to None for clarity (it will be ignored, since using csv of targets)
  • targ_min_radius --> set to None for clarity (it will be ignored, since using csv of targets)
  • pause_interval --> I'm not sure what our latest info on cooling is, but 590 sec is the nominal design limit. We can probably go a bit faster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant