Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLA CNN VAC Review (DR1) #31

Open
2 of 4 tasks
dylanagreen opened this issue Dec 30, 2024 · 0 comments
Open
2 of 4 tasks

DLA CNN VAC Review (DR1) #31

dylanagreen opened this issue Dec 30, 2024 · 0 comments
Assignees

Comments

@dylanagreen
Copy link

Contact Person: Jiaqi Zou
1 catalog file (fits), 1 README

Initial Checks:

  • Includes README (see below)
  • Columns in ALLCAPS (see below)
  • Extension names in ALLCAPS
  • Files include units (see below)

Initial Notes:

  • Some of the columns are not in ALLCAPS, for consistency and ease of use can you please update them to be in ALLCAPS? (e.g. 'healpix' and 'combine')
  • Can you please add units to the fits file where appropriate? (e.g. units of degrees for TARGET_RA and TARGET_DEC)
  • This looks to be an updated version of the EDR VAC, with two additional columns (healpix and combine). We can port the EDR README, but can you provide column descriptions for the new columns that were not in the EDR version?
@dylanagreen dylanagreen self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant