Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESI Strong Lensing Catalog VAC Review (DR1) #17

Open
2 tasks done
dylanagreen opened this issue Dec 30, 2024 · 0 comments
Open
2 tasks done

DESI Strong Lensing Catalog VAC Review (DR1) #17

dylanagreen opened this issue Dec 30, 2024 · 0 comments
Assignees
Labels
vac review Issues pertaining to VAC reviews

Comments

@dylanagreen
Copy link

Contact Person: Christopher Storfer
1 catalog file (csv), 1 README, 1 additional file

Initial Checks:

  • Includes README
  • Columns in ALLCAPS

Initial Notes:

  • Column 0 (an index column?) has no name. Can you please add a name or otherwise remove the column?
  • When you get an opportunity, please flesh out the README with a full data model for the currently included columns, as well as a contact person to release publicly.
  • There's an included jupyter notebook file, but it appears to be empty. Is this intended? If not, can you please update the notebook with the intended detail? Otherwise let's delete this file.
  • There's a version number in the VAC file, but not in the file path (i.e. /SL-VAC/v0), can you please add one?
@dylanagreen dylanagreen changed the title DESi Strong Lensing Catalog VAC Review (DR1) DESI Strong Lensing Catalog VAC Review (DR1) Dec 30, 2024
@dylanagreen dylanagreen self-assigned this Dec 30, 2024
@dylanagreen dylanagreen added the vac review Issues pertaining to VAC reviews label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vac review Issues pertaining to VAC reviews
Projects
None yet
Development

No branches or pull requests

1 participant