From 8b19d88c4f40c496ca0ff1922975daf5de4c6b5f Mon Sep 17 00:00:00 2001 From: Gregor Best Date: Thu, 16 Sep 2021 13:19:38 +0200 Subject: [PATCH] Don't fail on unsupported modes `gopls` asks for: mode: LoadMode(NeedName|NeedFiles|NeedCompiledGoFiles|NeedImports|NeedDeps|NeedTypesSizes|Unknown) which causes bazelpackagesdriver to error out with LoadMode(Unknown) (10000000000) not implemented Just logging this instead of returning a hard error allows package loadig to continue. I haven't yet observed problems with a combination of acme-lsp and gopls. --- driver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver.go b/driver.go index 26ed986..22d2061 100644 --- a/driver.go +++ b/driver.go @@ -85,7 +85,7 @@ func (d *bazelDriver) loadPackages(patterns ...string) (*driver.Response, error) log.Printf("mode: %v", d.cfg.Mode) unsupportedModes := d.cfg.Mode &^ supportedModes if unsupportedModes != 0 { - return nil, fmt.Errorf("%v (%b) not implemented", unsupportedModes, unsupportedModes) + log.Printf("%v (%b) not implemented", unsupportedModes, unsupportedModes) } if len(patterns) == 0 {