Support for Websocket over Http/2 and axum 0.8

[radudiaconu0]

I see that axum introduced here support fo websokcets over https/2. Can we have that too? And maybe support with axum too? Maybe an update to the future axum 0.8 will be good too

[szguoxz]

This crate seems not maintained any more, this is ODD.
Maybe go back to tungstenite-rs?
I switched to here from tungstenite-rs because I heard it's fast, but it's frustrated to see there's no checkin in last 6 months. It can not compile with latest Axum anymore.
Now I understand why people say: Fast is not the only thing you need to pay attention to. :-)

[littledivy]

You can do HTTP/2 WebSocket upgrade yourself and pass the upgraded stream to fastwebsockets.

Happy to accept PRs that makes HTTP/2 upgrades work with with_axum feature in this crate.

[radudiaconu0]

Yeh it cannot compile with the lastest axum (0.8)

)
| --- ^^^^^^^^^^^^^^^^^ the traitHandler<_, _>is not implemented for fn itemfn(Path, Query, IncomingUpgrade, State<Arc<...>>) -> ... {handle_ws_upgrade}

    
    pub async fn handle_ws_upgrade(
    Path(app_key): Path<String>,
    Query(params): Query<ConnectionQuery>,
    ws: upgrade::IncomingUpgrade,
    State(handler): State<Arc<ConnectionHandler>>,
) -> impl IntoResponse {
    // let (response, fut) = ws.upgrade().unwrap();
    // tokio::task::spawn(async move {
    //     if let Err(e) = handler.handle_socket(fut, app_key).await {
    //         eprintln!("Error in websocket adapter: {}", e);
    //     }
    // });
    // response
    return "Hello";
}

[radudiaconu0]

i hope somebody fixes it

[littledivy]

Fixed in 9101613