Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize invite-pages #39

Closed
r10s opened this issue Jul 26, 2024 · 3 comments
Closed

localize invite-pages #39

r10s opened this issue Jul 26, 2024 · 3 comments
Labels
enhancement actually in development, user visible enhancement

Comments

@r10s
Copy link
Member

r10s commented Jul 26, 2024

currently, they're english only.

as important parts anyway depend on javascript, it'd be find if translations rely on javascript as well

@r10s r10s added the enhancement actually in development, user visible enhancement label Jul 26, 2024
@r10s r10s moved this to Todo in onboard friends Jul 26, 2024
@link2xt
Copy link
Contributor

link2xt commented Aug 13, 2024

It uses https://www.i18next.com/
From https://www.i18next.com/overview/getting-started it seems that it should detect the language automatically.

Maybe removing

lng: (new URLSearchParams(window.location.search)).get('lang'),
is enough? I don't know how this is supposed to work, but for me (new URLSearchParams(window.location.search)).get('lang') typed into the console in Firefox returns null.

EDIT: actually URLSearchParams works like this: https://i.delta.chat/?lang=fr, https://i.delta.chat/?lang=ru
This code simply takes the language from the URL, but nobody passes it there.

EDIT: removing is not enough, but we can add language detector script.

@link2xt
Copy link
Contributor

link2xt commented Aug 13, 2024

Made a PR to add language detector: #41

@link2xt
Copy link
Contributor

link2xt commented Aug 13, 2024

Fixed with #41 and #42

@link2xt link2xt closed this as completed Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in onboard friends Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
Status: Done
Development

No branches or pull requests

2 participants