registerPrivateView makes app crash

[vinceyuan]

I registered a UIWebView as a private view using
[Delight registerPrivateView:_webView description:@"Weibo login web view"];

When Delight is not recording, there is no problem.
But when Delight is recording and I open this web view, the app will crash several seconds later.

Please take a look at this problem. Now I have to comment out the line of calling [Delight registerPrivateView].

iPhone 4S
iOS 5.1.1

[vinceyuan]

Maybe the problem is in unregisterPrivateView.
Even if I check whether the view is in privateViews, unregisterPrivateView makes the app crash.

[haugli]

Hi Vince,

Thanks for bringing this to our attention.

I think I've found the cause of the crash, and have pushed an update (v2.3.1).
Would you be able to try it out and let me know if it solves the issue?

Thanks,

Chris

[vinceyuan]

Hi Chris,

Thanks for the quick response.

I tried the new sdk. It still has problems. After I call the following lines of code, the app will receive memory warning, and then it will be terminated.

if (![Delight privateViews] containsObject:theView])
[Delight registerPrivateView:theView description:@"private"];

If I don't call registerPrivateView, the app will not receive memory warning. Sounds like when a private view is added, delight uses a lot of memory.

Even if I don't add a private view, delight uses too much memory. See the screens shot of Instruments. [Delight takeScreenshot] used 121MB memory (82.6% of total memory). Tested on iPhone 4S, iOS 5.1.1. (If you can't see the image, please send an email to vince.yuan@gmail.com ) I reported a similar problem on iPad1. I don't think it is a bug of Instruments.

Best Regards,
Vince

ÔÚ 27 Jul 2012£¬02:54£¬ Chris Haugli дµÀ£º

Hi Vince,

Thanks for bringing this to our attention.

I think I've found the cause of the crash, and have pushed an update (v2.3.1).
Would you be able to try it out and let me know if it solves the issue?

Thanks,

Chris

---

Reply to this email directly or view it on GitHub:
#2 (comment)

[haugli]

Hi Vince,

Could you email the Instruments screenshot, along with the crash log if possible, to chris@delight.io?

registerPrivateView just adds the view to an NSSet, so by itself it shouldn't have any noticeable effect on memory consumption. But if unregisterPrivateView doesn't get called with the same object at some future point in time, then that view will never get released (and its memory will never get freed). Could that be what's happening? If you check [[Delight privateViews] count] does the value make sense or does it keep increasing?

Best regards,

Chris