Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some deeptime.data only produce one state #303

Open
BissuelD opened this issue Jan 20, 2025 · 2 comments
Open

some deeptime.data only produce one state #303

BissuelD opened this issue Jan 20, 2025 · 2 comments

Comments

@BissuelD
Copy link

While running deeptime tutorials, I noticed deeptime.data.ellipsoids produces samples in one single state, seemingly regardless of the random seed provided or the sample size.

I did some tests on other datasets by directly running the provided notebooks without any modification.
Here are the list of datasets with similar issues I noticed, together with screenshots showing the state population issues:

Note : I did not try all provided dataset notebooks, so I don't know if the list above is exhaustive. Also, being quite new into Markov Models, I am sorry in advance if the terminolgy I use is incorrect or if one of the issues above is not related to the others.

I run on Debian 12 (bookworm), and use deeptime==0.4.4 installed via pip on a uv venv (see the full requirements.txt).

@BissuelD BissuelD changed the title some deeptime.data only produce one step some deeptime.data only produce one state Jan 20, 2025
@clonker
Copy link
Member

clonker commented Jan 20, 2025

Hmmm. That is definitely not right. Can you do me a favor and create a venv (via python -m venv .venv), activate it (via source .venv/bin/activate), clone the deeptime repository and install it into the venv with pip install . assuming the current working directory is inside the cloned repository? Then try again? I am just trying to rule out that there is something wrong with your python setup :)

@BissuelD
Copy link
Author

Thanks for your answer!

It seems there is indeed something wrong with the python setup I used: with cloned repositories and pip install . for both the latest official release (deeptime-0.4.4) and the latest commit of the code (deeptime-0.4.4+11.g5f85b3e) showed no issue.

After a few tests, I believe the pip install deeptime command is the culprit in my case. Here is a summary of what I tried (with a constant Python version ie. 3.10.7)

  • Building in a fresh venv from the cloned repository and pip install . (see the above paragraph) succeeds with no issue.
  • Using pip install deeptime in a fresh venv fails as described in my first post.
  • Using uv add deeptime (or uv pip install deeptime) in a fresh uv venv also fails the same way.
  • Creating a fresh conda env and using conda install deeptime seems to work fine.

My intuition was then to look at my pip command, but as 1) the pip install . from source works and 2) uv pip uses its own pip, not the one from the host, I suppose the issue is not that simple.

I do not have another machine available right now, but I guess the next step would be to see if using pip install deeptime on another machine allows to replicate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants