test(converters): remove long commented line to satisfy ruff E501

Signed-off-by: Arya Tayshete <[email protected]>

Author: xoaryaa

test/components/converters/test_csv_to_document.py

@@ -4,6 +4,7 @@
 
 import logging
 import os
+from pathlib import Path
 
 import pytest
 
@@ -17,10 +18,10 @@ def csv_converter():
 
 
 class TestCSVToDocument:
-    def test_init(self, csv_converter):
+    def test_init(self, csv_converter: CSVToDocument):
         assert isinstance(csv_converter, CSVToDocument)
 
-    def test_run(self, test_files_path):
+    def test_run(self, test_files_path: Path):
         """
         Test if the component runs correctly.
         """
@@ -38,7 +39,7 @@ def test_run(self, test_files_path):
         assert docs[1].meta["file_path"] == os.path.basename(files[1])
         assert docs[2].meta["file_path"] == os.path.basename(files[2])
 
-    def test_run_with_store_full_path_false(self, test_files_path):
+    def test_run_with_store_full_path_false(self, test_files_path: Path):
         """
         Test if the component runs correctly with store_full_path=False
         """
@@ -57,7 +58,7 @@ def test_run_with_store_full_path_false(self, test_files_path):
         assert docs[1].meta["file_path"] == "sample_2.csv"
         assert docs[2].meta["file_path"] == "sample_3.csv"
 
-    def test_run_error_handling(self, test_files_path, caplog):
+    def test_run_error_handling(self, test_files_path: Path, caplog: pytest.LogCaptureFixture):
         """
         Test if the component correctly handles errors.
         """
@@ -74,7 +75,7 @@ def test_run_error_handling(self, test_files_path, caplog):
         assert len(docs) == 2
         assert docs[0].meta["file_path"] == os.path.basename(paths[0])
 
-    def test_encoding_override(self, test_files_path, caplog):
+    def test_encoding_override(self, test_files_path: Path, caplog: pytest.LogCaptureFixture):
         """
         Test if the encoding metadata field is used properly
         """
@@ -103,7 +104,7 @@ def test_run_with_meta(self):
         # check that the metadata from the bytestream is merged with that from the meta parameter
         assert document.meta == {"name": "test_name", "language": "it"}
 
-    # --- NEW TESTS for row mode reviewer asks ---
+    # --- NEW TESTS for row mode ---
 
     def test_row_mode_with_missing_content_column_warns_and_fallbacks(self, tmp_path, caplog):
         csv_text = "a,b\r\n1,2\r\n3,4\r\n"
@@ -121,7 +122,7 @@ def test_row_mode_with_missing_content_column_warns_and_fallbacks(self, tmp_path
         # Fallback content is a readable listing
         assert "a: 1" in docs[0].content and "b: 2" in docs[0].content
 
-    def test_row_mode_meta_collision_prefixed(self, tmp_path):
+    def test_row_mode_meta_collision_prefixed(self, tmp_path: Path):
         # ByteStream meta has file_path and encoding; CSV also has those columns.
         csv_text = "file_path,encoding,comment\r\nrowpath.csv,latin1,ok\r\n"
         f = tmp_path / "collide.csv"
@@ -147,21 +148,20 @@ def test_init_validates_delimiter_and_quotechar(self):
         with pytest.raises(ValueError):
             CSVToDocument(quotechar='""')
 
-    def test_row_mode_large_file_warns(self, tmp_path, caplog):
-        # Build a ~1.2MB CSV to trigger the warning (threshold ~5MB in component;
-        # If you want to keep this super fast, you can comment this test out.)
-        rows = 60_000
-        header = "text,author\n"
-        body = "".join("hello,Ada\n" for _ in range(rows))
-        data = (header + body).encode("utf-8")
-        bs = ByteStream(data=data, meta={"file_path": "big.csv"})
+    def test_row_mode_large_file_warns(self, caplog: pytest.LogCaptureFixture, monkeypatch: pytest.MonkeyPatch):
+        # Make the threshold tiny so the warning always triggers, regardless of platform.
+        import haystack.components.converters.csv as csv_mod
+
+        monkeypatch.setattr(csv_mod, "_ROW_MODE_SIZE_WARN_BYTES", 1, raising=False)
+
+        bs = ByteStream(data=b"text,author\nhi,Ada\n", meta={"file_path": "big.csv"})
         conv = CSVToDocument(conversion_mode="row")
-        with caplog.at_level(logging.WARNING):
+        # Capture the converter module's logger explicitly for reliability across CI runners.
+        with caplog.at_level(logging.WARNING, logger="haystack.components.converters.csv"):
             _ = conv.run(sources=[bs])
-        # Not asserting exact MB value to avoid brittleness; look for the key phrase
         assert "parsing a large CSV" in caplog.text
 
-    def test_row_mode_with_content_column(self, tmp_path):
+    def test_row_mode_with_content_column(self, tmp_path: Path):
         """
         Each row becomes a Document, with `content` from a chosen column and other columns in meta.
         """
@@ -185,7 +185,7 @@ def test_row_mode_with_content_column(self, tmp_path):
         # still respects store_full_path default=False trimming when present
         assert os.path.basename(f) == docs[0].meta["file_path"]
 
-    def test_row_mode_without_content_column(self, tmp_path):
+    def test_row_mode_without_content_column(self, tmp_path: Path):
         """
         Without `content_column`, the content is a human-readable 'key: value' listing of the row.
         """
@@ -202,7 +202,7 @@ def test_row_mode_without_content_column(self, tmp_path):
         assert docs[0].meta["a"] == "1" and docs[0].meta["b"] == "2"
         assert docs[0].meta["row_number"] == 0
 
-    def test_row_mode_meta_merging(self, tmp_path):
+    def test_row_mode_meta_merging(self, tmp_path: Path):
         """
         File-level meta and explicit `meta` arg are merged into each row's meta.
         """