wip

Signed-off-by: Daniil Loktev <[email protected]>

Author: loktev-d

images/virtualization-artifact/pkg/controller/vm/internal/service/migration_volumes.go

@@ -262,10 +262,19 @@ func (s MigrationVolumesService) VolumesSynced(ctx context.Context, vmState stat
 		return false, fmt.Errorf("kvvm or kvvmi is nil")
 	}
 
-	migratable, _ := conditions.GetKVVMICondition(virtv1.VirtualMachineInstanceIsMigratable, kvvmiInCluster.Status.Conditions)
-	if migratable.Status != corev1.ConditionTrue {
-		log.Info("VirtualMachine is not migratable, volumes are not synced yet.")
-		return false, nil
+	readWriteOnceDisks, storageClassChangedDisks, err := s.getDisks(ctx, vmState)
+	if err != nil {
+		return false, err
+	}
+
+	// Only check KubeVirt's LiveMigratable condition if there are non-hotplugged RWO disks
+	// that require VD migration. Hotplugged RWO disks are handled by KubeVirt's block migration.
+	if len(readWriteOnceDisks) > 0 || len(storageClassChangedDisks) > 0 {
+		migratable, _ := conditions.GetKVVMICondition(virtv1.VirtualMachineInstanceIsMigratable, kvvmiInCluster.Status.Conditions)
+		if migratable.Status != corev1.ConditionTrue {
+			log.Info("VirtualMachine is not migratable, volumes are not synced yet.")
+			return false, nil
+		}
 	}
 
 	kvvmSynced := equality.Semantic.DeepEqual(builtKVVMWithMigrationVolumes.Spec.Template.Spec.Volumes, kvvmInCluster.Spec.Template.Spec.Volumes)
@@ -287,11 +296,6 @@ func (s MigrationVolumesService) VolumesSynced(ctx context.Context, vmState stat
 		return false, nil
 	}
 
-	readWriteOnceDisks, storageClassChangedDisks, err := s.getDisks(ctx, vmState)
-	if err != nil {
-		return false, err
-	}
-
 	readWriteOnceDisksSynced := s.areDisksSynced(builtKVVMWithMigrationVolumes, readWriteOnceDisks)
 	if !readWriteOnceDisksSynced {
 		log.Info("ReadWriteOnce disks are not synced yet")