t

Signed-off-by: Valeriy Khorunzhin <[email protected]>

Author: Valeriy Khorunzhin

crds/virtualmachineclasses.yaml

@@ -341,6 +341,9 @@ spec:
                             x-kubernetes-int-or-string: true
                         type: object
                     type: object
+                    x-kubernetes-validations:
+                      - message: The defaultCoreFraction must be one of the values in coreFractions
+                        rule: "!has(self.defaultCoreFraction) || self.defaultCoreFraction in self.coreFractions"
                   type: array
                 tolerations:
                   description: |-
@@ -838,6 +841,9 @@ spec:
                             x-kubernetes-int-or-string: true
                         type: object
                     type: object
+                    x-kubernetes-validations:
+                      - message: The defaultCoreFraction must be one of the values in coreFractions
+                        rule: "!has(self.defaultCoreFraction) || self.defaultCoreFraction in self.coreFractions"
                   type: array
                 tolerations:
                   description: |-

images/virtualization-artifact/pkg/controller/vm/internal/defaulter/core_fraction.go

@@ -59,9 +59,6 @@ func (d *CoreFractionDefaulter) Default(ctx context.Context, vm *v1alpha2.Virtua
 	defaultCoreFraction := d.getDefaultCoreFraction(vm, vmClass)
 	if defaultCoreFraction != "" {
 		vm.Spec.CPU.CoreFraction = defaultCoreFraction
-	} else {
-		// If no default is set in the class, use 100% as fallback.
-		vm.Spec.CPU.CoreFraction = "100%"
 	}
 
 	return nil
@@ -70,8 +67,10 @@ func (d *CoreFractionDefaulter) Default(ctx context.Context, vm *v1alpha2.Virtua
 // getDefaultCoreFraction finds the default core fraction from the VMClass sizing policy
 // that matches the VM's CPU cores count.
 func (d *CoreFractionDefaulter) getDefaultCoreFraction(vm *v1alpha2.VirtualMachine, vmClass *v1alpha3.VirtualMachineClass) string {
+	const defaultValue = "100%"
+
 	if vmClass == nil || len(vmClass.Spec.SizingPolicies) == 0 {
-		return ""
+		return defaultValue
 	}
 
 	for _, sp := range vmClass.Spec.SizingPolicies {
@@ -84,9 +83,9 @@ func (d *CoreFractionDefaulter) getDefaultCoreFraction(vm *v1alpha2.VirtualMachi
 			if sp.DefaultCoreFraction != nil {
 				return string(*sp.DefaultCoreFraction)
 			}
-			return ""
+			return defaultValue
 		}
 	}
 
-	return ""
+	return defaultValue
 }