Merge pull request Homebrew#16458 from Bo98/json-freeze

api: use freeze option for JSON parsing

Author: MikeMcQuaid

Library/Homebrew/api.rb

@@ -30,7 +30,7 @@ def self.fetch(endpoint)
       end
       raise ArgumentError, "No file found at #{Tty.underline}#{api_url}#{Tty.reset}" unless output.success?
 
-      cache[endpoint] = JSON.parse(output.stdout)
+      cache[endpoint] = JSON.parse(output.stdout, freeze: true)
     rescue JSON::ParserError
       raise ArgumentError, "Invalid JSON file: #{Tty.underline}#{api_url}#{Tty.reset}"
     end
@@ -96,7 +96,7 @@ def self.fetch_json_api_file(endpoint, target: HOMEBREW_CACHE_API/endpoint,
 
         mtime = insecure_download ? Time.new(1970, 1, 1) : Time.now
         FileUtils.touch(target, mtime: mtime) unless skip_download
-        JSON.parse(target.read)
+        JSON.parse(target.read, freeze: true)
       rescue JSON::ParserError
         target.unlink
         retry_count += 1
@@ -170,7 +170,7 @@ def self.write_names_file(names, type, regenerate:)
         return false, "signature mismatch"
       end
 
-      [true, JSON.parse(json_data["payload"])]
+      [true, JSON.parse(json_data["payload"], freeze: true)]
     end
 
     sig { params(path: Pathname).returns(T.nilable(Tap)) }

Library/Homebrew/api/cask.rb

@@ -47,13 +47,13 @@ def download_and_cache_data!
 
           cache["renames"] = {}
           cache["casks"] = json_casks.to_h do |json_cask|
-            token = json_cask.delete("token")
+            token = json_cask["token"]
 
             json_cask.fetch("old_tokens", []).each do |old_token|
               cache["renames"][old_token] = token
             end
 
-            [token, json_cask]
+            [token, json_cask.except("token")]
           end
 
           updated

Library/Homebrew/cask/cask.rb

@@ -349,7 +349,7 @@ def to_h
 
     def to_hash_with_variations
       if loaded_from_api? && !Homebrew::EnvConfig.no_install_from_api?
-        return api_to_local_hash(Homebrew::API::Cask.all_casks[token])
+        return api_to_local_hash(Homebrew::API::Cask.all_casks[token].dup)
       end
 
       hash = to_h

Library/Homebrew/formulary.rb

@@ -232,7 +232,7 @@ def self.load_formula_from_api(name, flags:)
       end
 
       dep_json["uses_from_macos"]&.each_with_index do |dep, index|
-        bounds = dep_json.fetch("uses_from_macos_bounds", [])[index] || {}
+        bounds = dep_json.fetch("uses_from_macos_bounds", [])[index].dup || {}
         bounds.deep_transform_keys!(&:to_sym)
         bounds.deep_transform_values! { |val| val.is_a?(String) ? val.to_sym : val }