Fixes to ProcessHelper

Author: Hecatron

QtSharp.CLI/Program.cs

@@ -129,7 +129,7 @@ static bool QueryQt(QtInfo qt, bool debug)
 
             string emptyFile = Platform.IsWindows ? "NUL" : "/dev/null";
             string output;
-            ProcessHelper.Run("gcc", string.Format("-v -E -x c++ {0}", emptyFile), out output, waitForExit: !Platform.IsWindows);
+            ProcessHelper.Run("gcc", string.Format("-v -E -x c++ {0}", emptyFile), out output);
             qt.Target = Regex.Match(output, @"Target:\s*(?<target>[^\r\n]+)").Groups["target"].Value;
 
             const string includeDirsRegex = @"#include <\.\.\.> search starts here:(?<includes>.+)End of search list";

QtSharp/ProcessHelper.cs

@@ -5,32 +5,46 @@ namespace QtSharp
 {
     public class ProcessHelper
     {
-        public static string Run(string path, string args, out string error, bool readOutputByLines = false, bool waitForExit = true)
+        public static string Run(string path, string args, out string error, bool readOutputByLines = false)
         {
             try
             {
                 using (Process process = new Process())
                 {
+                    Console.WriteLine("Run: " + path);
+                    Console.WriteLine("Args: " + args);
                     process.StartInfo.FileName = path;
                     process.StartInfo.Arguments = args;
                     process.StartInfo.UseShellExecute = false;
                     process.StartInfo.RedirectStandardOutput = true;
                     process.StartInfo.RedirectStandardError = true;
-                    process.Start();
-                    if (waitForExit)
+
+                    var reterror = "";
+                    var retout = "";
+                    process.OutputDataReceived += (sender, outargs) =>
                     {
-                        process.WaitForExit();
-                    }
-                    while (readOutputByLines && !process.StandardOutput.EndOfStream)
+                        if (retout != "" && outargs.Data != "") retout += "\r\n";
+                        retout += outargs.Data;
+                        Console.WriteLine("stdout: {0}", retout);
+                    };
+                    process.ErrorDataReceived += (sender, errargs) =>
                     {
-                        Console.WriteLine(process.StandardOutput.ReadLine());
-                    }
-                    error = process.StandardError.ReadToEnd();
+                        if (reterror != "" && errargs.Data != "") reterror += "\r\n";
+                        reterror += errargs.Data;
+                        Console.WriteLine("stderr: {0}", reterror);
+                    };
+
+                    process.Start();
+                    process.BeginOutputReadLine();
+                    process.BeginErrorReadLine();
+                    process.WaitForExit();
+                    process.CancelOutputRead();
+                    process.CancelErrorRead();
+
+                    error = reterror;
                     if (process.ExitCode != 0)
-                    {
-                        return string.Empty;
-                    }
-                    return readOutputByLines ? string.Empty : process.StandardOutput.ReadToEnd().Trim().Replace(@"\\", @"\");
+                        throw new Exception("Exit Code is not 0");
+                    return readOutputByLines ? string.Empty : retout.Trim().Replace(@"\\", @"\");
                 }
             }
             catch (Exception exception)