Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE+] Make a plan for how to write a unittest for ModelRunner #9867

Closed
Tracked by #9649
ChenyuLInx opened this issue Apr 5, 2024 · 1 comment · Fixed by #10196
Closed
Tracked by #9649

[SPIKE+] Make a plan for how to write a unittest for ModelRunner #9867

ChenyuLInx opened this issue Apr 5, 2024 · 1 comment · Fixed by #10196
Assignees
Labels
Refinement Maintainer input needed

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Apr 5, 2024

Description

make a plan for how to write a unit test for the ModelRunner, and implement it if possible.
This may require:

  • mocking adapter
  • utils/fixtures to generate manifest that we already have
  • Mocking logging system to capture logging behavior

This is not amid to have a completely tested ModelRunner. The goal should be to have a good understanding of what utils/fixtures are best for a runner's needs. And have one example to follow.

@ChenyuLInx ChenyuLInx changed the title Write a unittest for a runner Write a unittest for ModelRunner Apr 5, 2024
@ChenyuLInx ChenyuLInx changed the title Write a unittest for ModelRunner [SPIKE+] Understand how to write a unittest for ModelRunner Apr 8, 2024
@ChenyuLInx ChenyuLInx changed the title [SPIKE+] Understand how to write a unittest for ModelRunner [SPIKE+] Make a plan for how to write a unittest for ModelRunner Apr 8, 2024
@ChenyuLInx
Copy link
Contributor Author

ChenyuLInx commented Apr 8, 2024

Blocked on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement Maintainer input needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants