Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error_tag helper to ui.py #107

Closed
1 task done
QMalcolm opened this issue Apr 12, 2024 · 0 comments · Fixed by #108
Closed
1 task done

Add error_tag helper to ui.py #107

QMalcolm opened this issue Apr 12, 2024 · 0 comments · Fixed by #108
Assignees
Labels
enhancement New feature or request

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-common

Short description

We have a warning_tag in ui.py currently, which is super helpful. In dbt-labs/dbt-core#9886 we found that we needed an error_tag function as well. We added it to core temporarily as a stop gap, but it really should be provided by dbt-common instead.

Acceptance criteria

dbt-common provides a error_tag similar to warning_tag

Suggested Tests

string checking

Impact to Other Teams

N/A

Will backports be required?

N/A

Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant