don't create d->{error}{cpants} if there's no error

charsbar · daxim · commit f81487e2f720 · 2013-04-22T00:13:23.000+02:00
diff --git a/lib/Module/CPANTS/Kwalitee/CpantsErrors.pm b/lib/Module/CPANTS/Kwalitee/CpantsErrors.pm
@@ -24,7 +24,9 @@ sub analyse {
     my @eout=$sout->read;
     my @eerr=$serr->read;
     
-    $me->d->{error}{cpants}= (@eerr || @eout) ? join("\n",'STDERR:',@eerr,'STDOUT:',@eout) : '';
+    if (@eerr || @eout) {
+        $me->d->{error}{cpants}=join("\n",'STDERR:',@eerr,'STDOUT:',@eout);
+    }
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,9 @@ sub analyse {`
`24`	`24`	`my @eout=$sout->read;`
`25`	`25`	`my @eerr=$serr->read;`
`26`	`26`
`27`		`- $me->d->{error}{cpants}= (@eerr \|\| @eout) ? join("\n",'STDERR:',@eerr,'STDOUT:',@eout) : '';`
	`27`	`+ if (@eerr \|\| @eout) {`
	`28`	`+ $me->d->{error}{cpants}=join("\n",'STDERR:',@eerr,'STDOUT:',@eout);`
	`29`	`+ }`
`28`	`30`	`}`
`29`	`31`
`30`	`32`