added a core metric for non_portable_filenames: bad filenames that are not allowed or portable

Author: charsbar

AUTHORS

@@ -16,6 +16,8 @@ AUTHORS - Authors of and contributors to Module-CPANTS-Analyse
 
 =item L<Lars Dɪᴇᴄᴋᴏᴡ|https://metacpan.org/author/daxim>
 
+=item L<Kenichi Ishigaki|https://metacpan.org/author/ishigaki>
+
 =back
 
 =head2 Contributors
@@ -28,8 +30,6 @@ AUTHORS - Authors of and contributors to Module-CPANTS-Analyse
 
 =item L<Jérôme Quelin|https://metacpan.org/author/jquelin>
 
-=item L<Kenichi Ishigaki|https://metacpan.org/author/charsbar>
-
 =item L<Mike Doherty|https://metacpan.org/author/mdoherty>
 
 =item L<Reini Urban|https://metacpan.org/author/rurban>

Changes

@@ -8,6 +8,9 @@ Changes - Revision history for Module-CPANTS-Analyse
 
 =over
 
+=item add metric C<non_portable_filenames>
+(L<charsbar|https://metacpan.org/author/ishigaki>)
+
 =item numerous fixes for a smoother operation of www-cpants
 (L<charsbar|https://metacpan.org/author/ishigaki>)
 

lib/Module/CPANTS/Kwalitee/Files.pm

@@ -49,6 +49,14 @@ sub analyse {
                 $files{$name}{license} = $license;
             }
         }
+
+        # Some characters are not allowed or have special meanings
+        # under some environment thus should be avoided.
+        # Filenames that are not allowed under *nix can't be trapped
+        # here now as they are not extracted at all.
+        if ($name =~ /[\*\?"<>\|:[:^ascii:]]/) {
+            push @{$me->d->{non_portable_filenames} ||= []}, $name;
+        }
     }
 
     if (%licenses) {
@@ -309,6 +317,16 @@ sub kwalitee_indicators {
             return 1;
         },
     },
+    {
+        name=>'non_portable_filenames',
+        error=>qq{This distribution has at least one file with non-portable characters in its filename, which may cause problems under some environment},
+        remedy=>q{Rename those files with alphanumerical characters, or maybe remove them because in many cases they are automatically generated for local installation.},
+        code=>sub {
+            my $d=shift;
+            return 0 if $d->{non_portable_filenames};
+            return 1;
+        },
+    },
 ];
 }
 
@@ -387,6 +405,10 @@ Returns the Kwalitee Indicators datastructure.
 
 =item * no_stdin_for_prompting
 
+=item * no_large_files
+
+=item * non_portable_filenames
+
 =back
 
 =head1 SEE ALSO

t/02_kwalitee.t

@@ -4,7 +4,7 @@ use Test::NoWarnings;
 
 use Module::CPANTS::Kwalitee;
 
-my $CORE = 25;
+my $CORE = 26;
 my $OPTIONAL = 10; #is_extra set
 my $EXTRA = 15; #experimental?
 my $METRICS = $CORE + $OPTIONAL + $EXTRA;