Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe it doesn't matter, but this won't work #5

Open
kellyelton opened this issue Jan 17, 2016 · 0 comments
Open

Maybe it doesn't matter, but this won't work #5

kellyelton opened this issue Jan 17, 2016 · 0 comments

Comments

@kellyelton
Copy link

This won't work because if NInject can't resolve a type it'll throw an exception, so it'll never check the base class.

Also, If that wasn't the case(which you can code a proper working example of what was trying to be accomplished), doing it this way, none of the hubs would have access to anything registered in the ninject kernel you pass in.

Really what would be required is to not to inherit from the DefaultDependencyInjector, but instead to inherit from the interface and build it out from scratch...which you actually wouldn't have to do if the default could return back a list of all registered services.

Anyway, this hasn't been updated in years and is probably long forgotten, but I figured maybe it'd make sense to raise this issue.

It's also an issue because the documentation uses the same flawed code http://www.asp.net/signalr/overview/advanced/dependency-injection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant