Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to next tab playing audio / mute tab commands #246

Closed
timo opened this issue Nov 29, 2023 · 2 comments · Fixed by #311
Closed

go to next tab playing audio / mute tab commands #246

timo opened this issue Nov 29, 2023 · 2 comments · Fixed by #311

Comments

@timo
Copy link

timo commented Nov 29, 2023

things i can think of

  • go to the next tab that has audio
    • either skip muted tabs, or also go to muted tabs
  • mute the current tab / tab by letter / next tab that's playing audio
  • if possible, also make tabs that recently played audio targetable (for example if there was a notification sound you're unfamiliar with, and if it's short you can easily miss the time when it still shows the icon)
@david-tejada
Copy link
Owner

I am going to start working on this. I think everything you mentioned is doable. This is a draft of the commands and what each will do. For the mute/unmute commands I'm unsure if it's better to have two commands or just a command that switches the mute/unmute state. Let me know what you think and if there's something you'd like to be added.

  • go playing: Go to the next tab that has audio (muted or not).

  • go sound: Go to the next tab that has audio and is not muted.

  • go muted: Go to the next muted tab.

  • go last sound: Go to the tab that most recently started (it might have already stopped) playing audio.

  • mute/unmute current: Mute/unmute the current tab.

  • mute/unmute next: Mute/unmute the next tab that's playing audio and is not already muted/unmuted.

  • mute/unmute <target>: Mute/unmute a tab by letters.

@david-tejada
Copy link
Owner

david-tejada commented Sep 4, 2024

In Firefox is not possible to know if a muted tab has audio because of this bug: 1667585 - WebExtensions API tab type: audible property incorrect when tab is muted

I think go muted should go to the next muted tab that has audio playing. Because of the aforementioned bug this is not possible in Firefox. I think for the time being I will make go muted go to the next muted tab, regardless of if it has audio or not.

On the other hand I will make go playing go to the next tab that has audible set to true. This will make its behavior as intended in Chrome but in Firefox will ignore all tabs that are muted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants