Fix linting (#314)

* Fix linting npm script not working properly

* Update typescript and fix some linting errors

Author: david-tejada

package-lock.json

@@ -16,7 +16,7 @@
 		"lint:css": "stylelint src/**/*.css",
 		"lint:js": "xo",
 		"lint": "run-p lint:* check-types",
-		"pretest": "NODE_ENV=test run-p lint:* unused-exports build:mv3",
+		"pretest": "NODE_ENV=test run-p lint unused-exports build:mv3",
 		"test": "jest --runInBand",
 		"watch": "parcel watch src/mv2/manifest.json --dist-dir dist-mv2 --no-cache --no-hmr",
 		"watch:mv3": "parcel watch src/mv3/manifest.json --dist-dir dist-mv3 --no-cache --no-hmr",
@@ -268,7 +268,7 @@
 		"stylelint-config-prettier": "^9.0.5",
 		"ts-jest": "^29.0.5",
 		"ts-unused-exports": "^8.0.5",
-		"typescript": "^4.6.3",
+		"typescript": "^5.6.2",
 		"web-ext": "^7.4.0",
 		"xo": "^0.48.0"
 	},

package.json

@@ -5,16 +5,6 @@ import { getSetting } from "../settings/settingsManager";
 
 const DEFAULT_SCROLL_FACTOR = 0.66;
 
-// Officially "instant" is not part of the specification yet, although it works
-// in Firefox, Chrome and Safari.
-declare global {
-	interface ScrollToOptions {
-		left?: number;
-		top?: number;
-		behavior?: "auto" | "instant" | "smooth";
-	}
-}
-
 let lastScrollContainer: Element | undefined;
 let lastScrollFactor: number;
 

src/content/actions/scroll.ts

@@ -39,7 +39,9 @@ async function isWrongFrame(request: RequestFromBackground) {
 browser.runtime.onMessage.addListener(
 	async (
 		request: RequestFromBackground
-	): Promise<string | string[] | TalonAction[] | boolean | undefined> => {
+	): Promise<
+		string | number | string[] | TalonAction[] | boolean | undefined
+	> => {
 		if (await isWrongFrame(request)) return;
 
 		if ("target" in request) {

src/content/content.ts

@@ -71,7 +71,7 @@ function odometerIncrement<T>(odometer: number[], arrayOfArrays: T[][]) {
 
 		if (odometer[iOdometerDigit]! + 1 <= maxee) {
 			// Increment, and you're done...
-			odometer[iOdometerDigit]++;
+			odometer[iOdometerDigit]!++;
 			return true;
 		}