Skip to content

Commit 6808be3

Browse files
authored
Fix error releasing tab markers (#555)
1 parent 775b55c commit 6808be3

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/background/tabs/tabMarkers.ts

+13-9
Original file line numberDiff line numberDiff line change
@@ -136,18 +136,22 @@ async function setTabMarker(tabId: number, preferredMarker?: string) {
136136
* @returns The released marker or undefined if the tab doesn't have a marker.
137137
*/
138138
async function releaseTabMarker(tabId: number) {
139-
return store.withLock("tabMarkers", async (tabMarkers) => {
140-
const { free, assigned } = tabMarkers;
139+
return store.withLock(
140+
"tabMarkers",
141+
async (tabMarkers) => {
142+
const { free, assigned } = tabMarkers;
141143

142-
const marker = assigned[tabId];
143-
if (!marker) return [tabMarkers];
144+
const marker = assigned[tabId];
145+
if (!marker) return [tabMarkers];
144146

145-
delete assigned[tabId];
146-
free.push(marker);
147-
free.sort((a, b) => b.length - a.length || b.localeCompare(a));
147+
delete assigned[tabId];
148+
free.push(marker);
149+
free.sort((a, b) => b.length - a.length || b.localeCompare(a));
148150

149-
return [tabMarkers, marker];
150-
});
151+
return [tabMarkers, marker];
152+
},
153+
createTabMarkers
154+
);
151155
}
152156

153157
/**

0 commit comments

Comments
 (0)