Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] filter mode option #1962

Closed
2 tasks done
su55y opened this issue Mar 14, 2024 · 2 comments
Closed
2 tasks done

[REQUEST] filter mode option #1962

su55y opened this issue Mar 14, 2024 · 2 comments
Milestone

Comments

@su55y
Copy link

su55y commented Mar 14, 2024

Before opening a feature request

  • I checked the next branch to see if the feature has already been implemented
  • I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

In the rofi script, after filtering and selecting/keybind pressing, the only way I see to keep the filter is to restart rofi with the -filter option. Which is not even a complete solution to the problem, since there is also nowhere to get the value for the filter.

How do you know that this problem exists today? Why is this important?

This limits me and I do not have enough competences to implement it, that is why I am opening this report.

Who will benefit from it?

Me and possibly other rofi scripts authors.

Rofi version (rofi -v)

Version: 1.7.5

Configuration

Additional information

The intuitive way in my opinion is to have a mode option filter, by analogy with prompt, message etc., and then it would be convenient to take the value for the filter from the environment variable ROFI_INPUT.

A more straightforward way to do the above is the keep-filter mode option, by analogy with keep-selection, but I guess it less straightforward to implement.

@DaveDavenport
Copy link
Collaborator

In git you the filter box has history so its one binding to get old entry back.

But keep-filter might be a nice option.

@DaveDavenport DaveDavenport added this to the 1.7.6 milestone May 12, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants