Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping using own mapping table depends on column order #13

Open
micwij opened this issue Mar 10, 2023 · 1 comment
Open

Mapping using own mapping table depends on column order #13

micwij opened this issue Mar 10, 2023 · 1 comment

Comments

@micwij
Copy link

micwij commented Mar 10, 2023

Hi,

I tried SBGNview with a custom SBGN file and supplied my user-provided mapping table. Because I made the mapping table manually in an excel-file it coincidentally occurred, that the column for the parameter gene.id.type was not the first column but the second column and the first column was the parameter sbgn.gene.id.type. When I tried running it, it was not able to map any IDs. After some troubleshooting I tried creating a mini-mapping table in R (with the reverse column order), which had previously worked on a different SBGN file and it worked. After changing the column order it also worked with the actual file I was trying to visualize. This makes me think, that some part of the mapping refers to columns not (only) by name but (also) by order. For my understanding, this is not clearly indicated in the documentation of the function arguments. I would also personally prefer the function not to depend on column order if I am already indicating it by the name, but I think it would be okay if this is clearly indicated in the documentation.

Best,
Micha

@raw937

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants