diff --git a/datahub-frontend/test/app/ApplicationTest.java b/datahub-frontend/test/app/ApplicationTest.java index 77fda774a78e1..8b5827b2596f9 100644 --- a/datahub-frontend/test/app/ApplicationTest.java +++ b/datahub-frontend/test/app/ApplicationTest.java @@ -940,12 +940,12 @@ public void testHappyPathOidc() throws ParseException { assertEquals(TEST_USER, data.get("actor")); // Default expiration is 24h, so should always be less than current time + 1 day since it stamps // the time before this executes. Use a more generous tolerance to account for timezone - // differences - // and test execution time variations. + // differences, DST transitions, and test execution time variations. + // Increased tolerance to 22-26 hours to handle DST transitions (which can cause 1-hour shifts) Date maxExpectedExpiration = - new Date(System.currentTimeMillis() + (25 * 60 * 60 * 1000)); // 25 hours + new Date(System.currentTimeMillis() + (26 * 60 * 60 * 1000)); // 26 hours Date minExpectedExpiration = - new Date(System.currentTimeMillis() + (23 * 60 * 60 * 1000)); // 23 hours + new Date(System.currentTimeMillis() + (22 * 60 * 60 * 1000)); // 22 hours Date actualExpiration = claims.getExpirationTime(); assertTrue( diff --git a/datahub-web-react/src/alchemy-components/components/Table/Table.tsx b/datahub-web-react/src/alchemy-components/components/Table/Table.tsx index a825afb267e36..332c7f1e6f112 100644 --- a/datahub-web-react/src/alchemy-components/components/Table/Table.tsx +++ b/datahub-web-react/src/alchemy-components/components/Table/Table.tsx @@ -195,10 +195,9 @@ export const Table = ({ const canExpand = expandable?.rowExpandable?.(row); // Check if row is expandable const key = `row-${index}-${sortColumn ?? 'none'}-${sortOrder ?? 'none'}`; return ( - <> + {/* Render the main row */} { if (focusedRowIndex === index) { @@ -298,7 +297,7 @@ export const Table = ({ )} - + ); })} {footer} diff --git a/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx b/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx index 0be417440c889..6c1daead2892d 100644 --- a/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx +++ b/datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx @@ -72,7 +72,9 @@ export default function NavBarMenu({ menu, selectedKey, isCollapsed, iconSize, s return ( - {menu.items.map((item) => renderMenuItem(item))} + {menu.items.map((item) => ( + {renderMenuItem(item)} + ))} ); } diff --git a/datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx b/datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx index 2dc4f2ae02bf1..f4b7f65056f74 100644 --- a/datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx +++ b/datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx @@ -567,7 +567,7 @@ describe('formatTimezone', () => { expect(['EST', 'EDT']).toContain(nycAbbr); const londonAbbr = formatTimezone('Europe/London'); - expect(['GMT+1', 'BST', 'GMT']).toContain(londonAbbr); + expect(['GMT', 'BST']).toContain(londonAbbr); // Tokyo doesn't observe DST, so it's always GMT+9 expect(formatTimezone('Asia/Tokyo')).toBe('GMT+9'); diff --git a/datahub-web-react/src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx b/datahub-web-react/src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx index a2add3cbc4652..b67476bcc42e5 100644 --- a/datahub-web-react/src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx +++ b/datahub-web-react/src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx @@ -103,7 +103,7 @@ const CreateNewTagModal: React.FC = ({ onClose, open }) setSelectedOwnerUrns([]); } catch (e: any) { message.destroy(); - message.error('Failed to create tag. An unexpected error occurred'); + message.error(`Failed to create tag. ${e.message}`); } finally { setIsLoading(false); } @@ -136,7 +136,15 @@ const CreateNewTagModal: React.FC = ({ onClose, open }) ]; return ( - + {/* Tag Details Section */}