Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Type not allowing top concepts #13

Open
RaggedStaff opened this issue May 9, 2023 · 2 comments
Open

Product Type not allowing top concepts #13

RaggedStaff opened this issue May 9, 2023 · 2 comments

Comments

@RaggedStaff
Copy link

The connector is not allowing assignment of top concepts within Taxononies (specifically Product Type, may apply to other taxons).

Given the sparse nature of the DFC Taxonomies, I had assumed (and I think agreed with Florence) that we would default up to a level that worked. For example: a Plum tomato, would default up to "Tomato" as there is no subclass for Plum Tomatoes. or a Loquat would default to Fruit.

@RaggedStaff
Copy link
Author

This is related to issue #9

@rioug
Copy link

rioug commented Oct 31, 2023

This is blocking OFN, as we can't use any level of Product Type but the narrowest one. Ie :

  • we can't use Drink -> Soft Drink, modelled as a DataFoodConsortium::Connector::SKOSInstance in the connector
  • we can only use the most specific one Drink -> Soft Drink -> Lemonade, modelled as a DataFoodConsortium::Connector::SKOSConcept in the connector

Ideally all levels of Product Type should be modelled as DataFoodConsortium::Connector::SKOSConcept. Also none of the SKOSConcept property are set: broaders, schemes, narrowers and prefLabels. This makes it really difficult to try and match OFN taxonomies with DFC Product Types, as there is no easy way to traverse the Product Type tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants