Skip to content

Commit 3beaad9

Browse files
Merge pull request #1498 from datacite/consortium-admin-bug
Downcase consortium ID when determining access to individual DOI records for cases where `doi.provider.consortium_id` is downcased
2 parents 07cee7f + 35e5da4 commit 3beaad9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

app/models/concerns/authenticable.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,9 @@ def not_allowed_by_doi_and_user(doi: nil, user: nil)
221221
return true if user.blank?
222222
return false if %w[staff_admin staff_user].include?(user.role_id)
223223
if %w[consortium_admin].include?(user.role_id) &&
224-
user.provider_id.present? &&
225-
user.provider_id.upcase == doi.provider.consortium_id
224+
user.provider_id.present? &&
225+
doi.provider&.consortium_id&.present? &&
226+
user.provider_id.downcase == doi.provider.consortium_id.downcase
226227
return false
227228
end
228229
if %w[provider_admin provider_user].include?(user.role_id) &&

0 commit comments

Comments
 (0)