remove test_redash_dashboard_crawler_crawls_dashboards_with_debug_listing_upper_limit entirely dependent on legacy dashboards and fmt

Author: pritishpai

tests/integration/assessment/test_dashboards.py

@@ -32,19 +32,6 @@ def test_redash_dashboard_crawler_crawls_dashboard(ws, make_dashboard, inventory
     assert dashboards == [Dashboard.from_sdk_redash_dashboard(dashboard)]
 
 
-@pytest.mark.skip(reason="Legacy dashboard creation is no longer supported by Databricks.")
-def test_redash_dashboard_crawler_crawls_dashboards_with_debug_listing_upper_limit(
-    ws, make_dashboard, inventory_schema, sql_backend
-) -> None:
-    for _ in range(2):  # Create two dashboards, expect one to be snapshotted due to upper limit below
-        make_dashboard()
-    crawler = RedashDashboardCrawler(ws, sql_backend, inventory_schema, debug_listing_upper_limit=1)
-
-    dashboards = list(crawler.snapshot())
-
-    assert len(dashboards) == 1
-
-
 def test_lakeview_dashboard_crawler_crawls_dashboards(
     ws, make_lakeview_dashboard, inventory_schema, sql_backend
 ) -> None:
@@ -72,7 +59,6 @@ def test_lakeview_dashboard_crawler_crawls_dashboard(
     assert dashboards == [Dashboard.from_sdk_lakeview_dashboard(dashboard)]
 
 
-
 def test_lakeview_dashboard_ownership_is_me(runtime_ctx, make_lakeview_dashboard) -> None:
     """Lakeview dashboard do not have a `creator` field, thus we fall back on the parent workspace path owner"""
     sdk_lakeview_dashboard = make_lakeview_dashboard()

tests/integration/conftest.py

@@ -542,7 +542,6 @@ def make_query(self, **kwargs) -> LegacyQuery:
         self._queries.append(query)
         return query
 
-
     def make_lakeview_dashboard(self, **kwargs) -> SdkLakeviewDashboard:
         dashboard = self._make_lakeview_dashboard(**kwargs)
         self._lakeview_query_id = "query"  # Hardcoded query name in the `make_lakeview_dashboard` fixture

tests/integration/source_code/test_queries.py

@@ -1,7 +1,7 @@
-import pytest
 from databricks.labs.lsql.backends import Row
 
-from databricks.labs.ucx.source_code.base import DirectFsAccess, LineageAtom, UsedTable
+from databricks.labs.ucx.source_code.base import DirectFsAccess, LineageAtom
+
 
 def test_query_linter_lints_queries_and_stores_dfsas_and_tables(simple_ctx) -> None:
     query_with_dfsa = simple_ctx.make_query(sql_query="SELECT * from csv.`dbfs://some_folder/some_file.csv`")
@@ -33,7 +33,8 @@ def test_query_linter_lints_queries_and_stores_dfsas_and_tables(simple_ctx) -> N
                     object_type="QUERY",
                     object_id=f"no-dashboard-id/{query_with_dfsa.id}",
                     other={"name": query_with_dfsa.name},
-                )],
+                )
+            ],
             path="dbfs://some_folder/some_file.csv",
             is_read=True,
             is_write=False,