Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Oct 28, 2025

Changes

What does this PR do?

  • Support databricks credentials
  • Standardize usages of credentials manager

Linked issues

Progresses #1008

Functionality

  • added relevant user documentation
  • modified existing command: databricks labs lakebridge ...

Tests

  • manually tested
  • added unit tests
  • added integration tests

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 68.33333% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.37%. Comparing base (338e93c) to head (75611fb).

Files with missing lines Patch % Lines
.../labs/lakebridge/connections/credential_manager.py 77.14% 6 Missing and 2 partials ⚠️
...abs/lakebridge/assessments/configure_assessment.py 33.33% 2 Missing ⚠️
...s/assessments/synapse/dedicated_sqlpool_extract.py 0.00% 2 Missing ⚠️
.../assessments/synapse/monitoring_metrics_extract.py 0.00% 2 Missing ⚠️
.../assessments/synapse/serverless_sqlpool_extract.py 0.00% 2 Missing ⚠️
...resources/assessments/synapse/workspace_extract.py 0.00% 2 Missing ⚠️
...databricks/labs/lakebridge/assessments/profiler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   65.23%   65.37%   +0.13%     
==========================================
  Files         100      100              
  Lines        8504     8536      +32     
  Branches      875      876       +1     
==========================================
+ Hits         5548     5580      +32     
  Misses       2769     2769              
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

✅ 51/51 passed, 9 flaky, 3m31s total

Flaky tests:

  • 🤪 test_validate_non_empty_tables (12ms)
  • 🤪 test_validate_mixed_checks (156ms)
  • 🤪 test_validate_invalid_schema_path (1ms)
  • 🤪 test_validate_invalid_source_tech (304ms)
  • 🤪 test_validate_table_not_found (0s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (18.912s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (7.78s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (5.687s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (12.386s)

Running from acceptance #3059

# Conflicts:
#	src/databricks/labs/lakebridge/reconcile/connectors/jdbc_reader.py
#	src/databricks/labs/lakebridge/reconcile/connectors/oracle.py
@m-abulazm m-abulazm marked this pull request as ready for review November 10, 2025 14:31
@m-abulazm m-abulazm requested a review from a team as a code owner November 10, 2025 14:31
@m-abulazm m-abulazm added tech debt design flaws and other cascading effects internal technical pr's not end user facing and removed do-not-merge labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal technical pr's not end user facing tech debt design flaws and other cascading effects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants