Commit 56a5e69
committed
Add
The publish step for the manifest `ucode setup` authors. Validates, shows what
would change, confirms, then writes it to the workspace via the clients added in
the parent commit.
Updates in place rather than replacing. When the workspace already has a config,
`apply` PATCHes it using its resource name (read back from the existing-config
GET, which `normalize_managed_config` preserves). Delete-then-create was the
original plan — v0's Create returns ALREADY_EXISTS — but it has a window where the
workspace has *no* managed config, and if the create failed there every developer
would silently fall back to their own settings until someone re-ran the command.
The server applies the update mask inside a single entity-store update, so a
failed PATCH leaves the current config intact. It is still a whole-manifest write:
every path ucode owns is sent, so a field the admin dropped on a re-run is cleared
rather than left behind.
Refuses to publish when it cannot tell whether a config already exists. A failed
existence check used to be the one case where "just try the create" would either
duplicate or silently overwrite an admin's work, so an unreadable check is a hard
error naming the reason rather than a warning.
`_explain_publish_failure` maps the failures an admin will actually hit.
FEATURE_DISABLED is the likely first experience — the CRUD flag is off by default —
so it names `codingAgentConfigCrudEnabled` instead of printing an HTTP 400.
INVALID_PARAMETER_VALUE is passed through verbatim: the server names the offending
field, which beats any paraphrase.
`--yes` skips the confirmation for CI; `--dry-run` validates and previews without
writing. The admin gate and validation both run before anything is sent, so an
invalid manifest or a non-admin costs no round trip.
README documents the publish step and drops the "no partial update yet" caveat,
which the PATCH path makes untrue.
Verified against eng-ml-inference.staging: `apply --dry-run` authenticated,
verified admin, rendered the summary, detected the existing config, and chose the
update path without writing.
Tests: 19 cases. Mutation-verified three ways — always-create instead of PATCH,
publishing despite an unreadable existence check, and publishing an invalid
manifest each fail a specific test. Also covers that `typer.Exit(0)` isn't caught
by the command's own RuntimeError handler, the same trap `setup` hit.
Co-authored-by: Isaacucode apply: publish the authored managed config1 parent 03a3f13 commit 56a5e69
4 files changed
Lines changed: 393 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
198 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
199 | 214 | | |
200 | 215 | | |
201 | 216 | | |
| |||
222 | 237 | | |
223 | 238 | | |
224 | 239 | | |
| 240 | + | |
| 241 | + | |
225 | 242 | | |
226 | 243 | | |
227 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
1967 | 1967 | | |
1968 | 1968 | | |
1969 | 1969 | | |
| 1970 | + | |
| 1971 | + | |
| 1972 | + | |
| 1973 | + | |
| 1974 | + | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
1970 | 1998 | | |
1971 | 1999 | | |
1972 | 2000 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
| 24 | + | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
27 | 30 | | |
28 | 31 | | |
29 | 32 | | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| |||
876 | 880 | | |
877 | 881 | | |
878 | 882 | | |
879 | | - | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
0 commit comments