gcp-sa-provisioning corrections regarding issue #168 (#169)

* Update README.md

* Update README.md

* Correct spelling of module gcp-sa-provisioning to match example script

* Correct service_account value

* Rename module reference to not overlap with gcp-basic

* Provider further documentation that dashes or underscores in the prefix variable will cause deployment errors

* Whitespace

* Update README.md

Author: sysopmatt

Diff for: examples/gcp-sa-provisionning/README.md renamed to examples/gcp-sa-provisioning/README.md

@@ -12,14 +12,14 @@ In this template, we create a [Service Account](https://cloud.google.com/iam/doc
 
 - The built-in roles of Kubernetes Admin and Compute Storage Admin needs to be available
 
-- you need to run `glcoud auth application-default login` and login with your google account
+- you need to run `gcloud auth application-default login` and login with your google account
 
 ## Run as an SA 
 
-You can do the same thing by provisionning a service account that will have the same permissions - and associate the key associated to it.
+You can do the same thing by provisioning a service account that will have the same permissions - and associate the key associated to it.
 
 
-## Run the tempalte
+## Run the template
 
 - You need to fill in the variables.tf 
 - run `terraform init`

Diff for: examples/gcp-sa-provisionning/init.tf renamed to examples/gcp-sa-provisioning/init.tf

@@ -1,4 +1,4 @@
-module "gcp-basic" {
+module "gcp-sa-provisioning" {
   source         = "github.com/databricks/terraform-databricks-examples/modules/gcp-sa-provisioning"
   google_project = var.google_project
   prefix         = var.prefix

Diff for: examples/gcp-sa-provisionning/main.tf renamed to examples/gcp-sa-provisioning/main.tf

@@ -0,0 +1,4 @@
+output "service_account" {
+  value       = module.gcp-sa-provisioning.service_account
+  description = "Add this email as a user in the Databricks account console"
+}

Diff for: examples/gcp-sa-provisioning/outputs.tf

@@ -5,7 +5,7 @@ variable "google_project" {
 
 variable "prefix" {
   type        = string
-  description = "Prefix to use in generated service account name"
+  description = "Prefix to use in generated service account name.  This should not contain underscores or dashes."
 }
 
 variable "delegate_from" {

Diff for: examples/gcp-sa-provisionning/variables.tf renamed to examples/gcp-sa-provisioning/variables.tf

@@ -1,4 +1,4 @@
-sa provisionning
+# Provisioning a Google Service Account that can be used to deploy Databricks workspace on GCP
 =========================
 
 In this template, we show how to deploy a service account that can be used to deploy gcp workspaces.
@@ -12,11 +12,11 @@ In this template, we create a [Service Account](https://cloud.google.com/iam/doc
 
 - The built-in roles of Kubernetes Admin and Compute Storage Admin needs to be available
 
-- you need to run `glcoud auth application-default login` and login with your google account
+- you need to run `gcloud auth application-default login` and login with your google account
 
 ## Run as an SA 
 
-You can do the same thing by provisionning a service account that will have the same permissions - and associate the key associated to it.
+You can do the same thing by provisioning a service account that will have the same permissions - and associate the key associated to it.
 
 
 ## Run the tempalte

Diff for: examples/gcp-sa-provisionning/outputs.tf

@@ -20,7 +20,6 @@ resource "google_service_account_iam_policy" "impersonatable" {
   policy_data        = data.google_iam_policy.this.policy_data
 }
 
-
 resource "google_project_iam_custom_role" "workspace_creator" {
   role_id = "${var.prefix}_workspace_creator"
   title   = "Databricks Workspace Creator by Aleks"