refactor(query): remove system.query_log and system.queries_profile_log (#18155)

* refactor(query): remove system.query_log and system.queries_profile_log

* refactor(query): remove system.query_log and system.queries_profile_log

* refactor(query): remove system.query_log and system.queries_profile_log

Author: zhang2014

src/query/service/src/databases/system/system_database.rs

@@ -51,9 +51,7 @@ use databend_common_storages_system::OneTable;
 use databend_common_storages_system::PasswordPoliciesTable;
 use databend_common_storages_system::ProceduresTable;
 use databend_common_storages_system::ProcessesTable;
-use databend_common_storages_system::QueriesProfilingTable;
 use databend_common_storages_system::QueryCacheTable;
-use databend_common_storages_system::QueryLogTable;
 use databend_common_storages_system::RolesTable;
 use databend_common_storages_system::SettingsTable;
 use databend_common_storages_system::StagesTable;
@@ -157,17 +155,12 @@ impl SystemDatabase {
                 TempFilesTable::create(sys_db_meta.next_table_id()),
                 TasksTable::create(sys_db_meta.next_table_id()),
                 TaskHistoryTable::create(sys_db_meta.next_table_id()),
-                QueriesProfilingTable::create(sys_db_meta.next_table_id()),
                 LocksTable::create(sys_db_meta.next_table_id(), ctl_name),
                 NotificationsTable::create(sys_db_meta.next_table_id()),
                 NotificationHistoryTable::create(sys_db_meta.next_table_id()),
                 ViewsTableWithHistory::create(sys_db_meta.next_table_id(), ctl_name),
                 TemporaryTablesTable::create(sys_db_meta.next_table_id()),
                 DictionariesTable::create(sys_db_meta.next_table_id()),
-                Arc::new(QueryLogTable::create(
-                    sys_db_meta.next_table_id(),
-                    config.query.max_query_log_size,
-                )),
                 Arc::new(ClusteringHistoryTable::create(
                     sys_db_meta.next_table_id(),
                     config.query.max_query_log_size,

src/query/service/src/global_services.rs

@@ -34,7 +34,6 @@ use databend_common_meta_store::MetaStoreProvider;
 use databend_common_storage::DataOperator;
 use databend_common_storage::ShareTableConfig;
 use databend_common_storages_hive::HiveCreator;
-use databend_common_storages_system::ProfilesLogQueue;
 use databend_common_tracing::GlobalLogger;
 use databend_common_users::builtin::BuiltIn;
 use databend_common_users::RoleCacheManager;
@@ -163,8 +162,6 @@ impl GlobalServices {
             CloudControlApiProvider::init(addr, config.query.cloud_control_grpc_timeout).await?;
         }
 
-        ProfilesLogQueue::init(config.query.max_cached_queries_profiles);
-
         #[cfg(feature = "enable_queries_executor")]
         {
             GlobalQueriesExecutor::init()?;

src/query/service/src/interpreters/common/query_log.rs

@@ -22,7 +22,6 @@ use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 use databend_common_storages_system::LogType;
 use databend_common_storages_system::QueryLogElement;
-use databend_common_storages_system::QueryLogQueue;
 use databend_common_version::DATABEND_COMMIT_VERSION;
 use log::error;
 use log::info;
@@ -71,7 +70,7 @@ impl InterpreterQueryLog {
         info!(target: "databend::log::query", "{}", event_str);
         // log the query event in the system log
         info!("query: {} becomes {:?}", event.query_id, event.log_type);
-        QueryLogQueue::instance()?.append_data(event)
+        Ok(())
     }
 
     pub fn fail_to_start(ctx: Arc<QueryContext>, err: ErrorCode) {

src/query/service/src/interpreters/interpreter.rs

@@ -41,8 +41,6 @@ use databend_common_pipeline_core::SourcePipeBuilder;
 use databend_common_sql::plans::Plan;
 use databend_common_sql::PlanExtras;
 use databend_common_sql::Planner;
-use databend_common_storages_system::ProfilesLogElement;
-use databend_common_storages_system::ProfilesLogQueue;
 use databend_storages_common_cache::CacheManager;
 use derive_visitor::DriveMut;
 use derive_visitor::VisitorMut;
@@ -363,11 +361,6 @@ pub fn on_execution_finished(info: &ExecutionInfo, query_ctx: Arc<QueryContext>)
                 statistics_desc: get_statistics_desc(),
             })?
         );
-        let profiles_queue = ProfilesLogQueue::instance()?;
-        profiles_queue.append_data(ProfilesLogElement {
-            query_id: query_ctx.get_id(),
-            profiles: query_profiles,
-        })?;
     }
 
     hook_clear_m_cte_temp_table(&query_ctx)?;

src/query/service/src/servers/admin/admin_service.rs

@@ -75,10 +75,6 @@ impl AdminService {
                 "/v1/cluster/list",
                 get(super::v1::cluster::cluster_list_handler),
             )
-            .at(
-                "v1/queries/:query_id/profiling",
-                get(super::v1::query_profiling::query_profiling_handler),
-            )
             .at(
                 "v1/queries/:query_id/graph_dump",
                 get(super::v1::query_dump::running_query_dump),

src/query/service/src/servers/admin/v1/mod.rs

@@ -17,7 +17,6 @@ pub mod config;
 pub mod instance_status;
 pub mod processes;
 pub mod query_dump;
-pub mod query_profiling;
 pub mod settings;
 pub mod stream_status;
 pub mod system;

src/query/service/src/servers/admin/v1/query_profiling.rs

@@ -25,7 +25,6 @@ use futures_util::future::BoxFuture;
 use serde::Deserialize;
 use serde::Serialize;
 
-use crate::servers::flight::v1::actions::get_profile::get_profile;
 use crate::servers::flight::v1::actions::get_running_query_dump::get_running_query_dump;
 use crate::servers::flight::v1::actions::init_query_env::init_query_env;
 use crate::servers::flight::v1::actions::init_query_env::INIT_QUERY_ENV;
@@ -37,7 +36,6 @@ use crate::servers::flight::v1::actions::start_prepared_query::start_prepared_qu
 use crate::servers::flight::v1::actions::system_action::system_action;
 use crate::servers::flight::v1::actions::truncate_table::truncate_table;
 use crate::servers::flight::v1::actions::truncate_table::TRUNCATE_TABLE;
-use crate::servers::flight::v1::actions::GET_PROFILE;
 use crate::servers::flight::v1::actions::GET_RUNNING_QUERY_DUMP;
 use crate::servers::flight::v1::actions::INIT_QUERY_FRAGMENTS;
 use crate::servers::flight::v1::actions::KILL_QUERY;
@@ -136,6 +134,5 @@ pub fn flight_actions() -> FlightActions {
         .action(KILL_QUERY, kill_query)
         .action(SET_PRIORITY, set_priority)
         .action(SYSTEM_ACTION, system_action)
-        .action(GET_PROFILE, get_profile)
         .action(GET_RUNNING_QUERY_DUMP, get_running_query_dump)
 }

src/query/service/src/servers/flight/v1/actions/flight_actions.rs

@@ -13,7 +13,6 @@
 // limitations under the License.
 
 mod flight_actions;
-mod get_profile;
 mod get_running_query_dump;
 mod init_query_env;
 mod init_query_fragments;
@@ -31,7 +30,6 @@ use databend_common_exception::Result;
 use databend_common_settings::Settings;
 pub use flight_actions::flight_actions;
 pub use flight_actions::FlightActions;
-pub use get_profile::GET_PROFILE;
 pub use get_running_query_dump::GET_RUNNING_QUERY_DUMP;
 pub use init_query_env::INIT_QUERY_ENV;
 pub use init_query_fragments::init_query_fragments;