Merge pull request #9337 from xudong963/complete

feat: support complete for sqllogictest

Author: mergify[bot]

Cargo.lock

@@ -17,7 +17,7 @@ regex = "1"
 reqwest = { version = "0.11.13", features = ["json"] }
 serde = "1.0.150"
 serde_json = "1.0.89"
-sqllogictest = "0.9.0"
+sqllogictest = { git = "https://github.com/xudong963/sqllogictest-rs", branch = "runner" }
 thiserror = "1.0.37"
 tokio = { version = "1.21.1", features = ["full"] }
 walkdir = "2.3.2"

tests/sqllogictests/Cargo.toml

@@ -26,6 +26,11 @@ Run tests under specific file. This is the most commonly used command because us
 cargo run -p sqllogictests -- --run_file <file_name>
 ```
 ---
+Auto complete test file which is very convenient. What you need to do is just a final check to see if the generated results meet expectations.
+```
+cargo run -p sqllogictests -- --run_file <file_name> --complete
+```
+---
 For more information, run help command:
 ```shell
 cargo run -p sqllogictests -- --help

tests/sqllogictests/README.md

@@ -43,7 +43,7 @@ pub struct SqlLogicTestArgs {
 
     // Set handler to run tests
     #[arg(
-        short = 'c',
+        short = 'l',
         long = "handlers",
         use_value_delimiter = true,
         value_delimiter = ',',
@@ -59,4 +59,13 @@ pub struct SqlLogicTestArgs {
         default_value = "tests/sqllogictests/suites"
     )]
     pub suites: String,
+
+    // If enable complete mode
+    #[arg(
+        short = 'c',
+        long = "complete",
+        default_missing_value = "true",
+        help = "The arg is used to enable auto complete mode"
+    )]
+    pub complete: bool,
 }

tests/sqllogictests/src/arg.rs

@@ -17,6 +17,8 @@ use std::path::PathBuf;
 
 use clap::Parser;
 use client::ClickhouseHttpClient;
+use sqllogictest::default_validator;
+use sqllogictest::update_test_file;
 use sqllogictest::DBOutput;
 use walkdir::DirEntry;
 use walkdir::WalkDir;
@@ -174,8 +176,16 @@ async fn run_suits(suits: ReadDir, databend: Databend) -> Result<()> {
                     continue;
                 }
             }
-            println!("test file: [{}] is running", file_name,);
-            runner.run_file_async(file.unwrap().path()).await?;
+            if args.complete {
+                let col_separator = " ";
+                let validator = default_validator;
+                update_test_file(file.unwrap().path(), &mut runner, col_separator, validator)
+                    .await
+                    .unwrap();
+            } else {
+                println!("test file: [{}] is running", file_name,);
+                runner.run_file_async(file.unwrap().path()).await?;
+            }
         }
     }