Skip to content

remove useless if condition#227

Open
xiagw wants to merge 1 commit intodatabacker:masterfrom
xiagw:remove-useless-if
Open

remove useless if condition#227
xiagw wants to merge 1 commit intodatabacker:masterfrom
xiagw:remove-useless-if

Conversation

@xiagw
Copy link

@xiagw xiagw commented May 21, 2023

No description provided.

@deitch
Copy link
Collaborator

deitch commented May 21, 2023

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

@xiagw
Copy link
Author

xiagw commented May 22, 2023

Is this a useless if statement? If the directory doesn't exist, this could return an exit code of 1, which could cause an error.

Because "set -e" is not enabled, it will not exit on error.

@deitch
Copy link
Collaborator

deitch commented May 22, 2023

True, although it should have been set. But this doesn't change anything either. Wy bother?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants