Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to device support #70

Open
asmeurer opened this issue Oct 18, 2024 · 2 comments
Open

Improvements to device support #70

asmeurer opened this issue Oct 18, 2024 · 2 comments

Comments

@asmeurer
Copy link
Member

#59 added support for basic devices. Some improvements that could be made:

  • Factor out the device checking logic (into a decorator?)
  • Add devices that don't support certain dtypes (non-support for float64/complex128 being the most common)
  • Allow the user to manually create custom "devices" with certain properties (probably via the flags API).
  • Better testing for device support. This ideally should go in array-api-tests, but currently it doesn't test devices at all, so it would be useful to have some basic tests here.
@ogrisel
Copy link

ogrisel commented Oct 21, 2024

I tried to run the scikit-learn tests with array-api-strict on the non-default device and I got some failures that do not happen with PyTorch and non-default device. So I suspect there is something fishy happening with the new devices in array-api-strict but I have not investigated the root cause yet.

scikit-learn/scikit-learn#30090

@betatim
Copy link
Member

betatim commented Oct 21, 2024

I'll take a look/investigate that failure further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants