Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make one of the devices have a lower maximum float precision #64

Open
betatim opened this issue Oct 3, 2024 · 2 comments
Open

Make one of the devices have a lower maximum float precision #64

betatim opened this issue Oct 3, 2024 · 2 comments

Comments

@betatim
Copy link
Member

betatim commented Oct 3, 2024

As a follow up to #56: it would be useful to make one of the "devices" have a lower maximum float precision than the rest. To mirror what, for example, PyTorch's MPS device does (this is the "Apple silicon" GPU in modern MacBooks).

I think having a "lower maximum precision" device would be the last piece we'd need in scikit-learn to be able to find all "user errors" when writing array API code. This way people writing array API code don't need to have a GPU available to find and debug the errors you get when using a device that isn't a CPU.

What do people think?

cc @ogrisel

@asmeurer
Copy link
Member

asmeurer commented Oct 3, 2024

My thinking is that the default set of devices should cover the important use-cases (including this), but you should also be able to manually set what devices are active using the flags API.

@asmeurer
Copy link
Member

asmeurer commented Oct 3, 2024

This is related to #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants