RFC: rm __array__, add __buffer__ #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The matching SciPy PR: scipy/scipy#22189 |
ev-br
force-pushed
the
buffer_protocol
branch
from
7162807 to
df7b4d1
Compare
ev-br
force-pushed
the
buffer_protocol
branch
from
df7b4d1 to
4fcb9e6
Compare
ev-br
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try getting rid of
__array__, replace with the buffer protocol's__buffer__.cross-ref #67, #69
This does not seem to fix gh-102.
scipytests pass locally.Replacing
__array__with__buffer__makes code marginally simpler. Effectively bumps the python requirement to 3.12+ though.So maybe this is a temp solution until
dlpackmatures.¯\_(ツ)_/¯