Skip to content

Commit 826cde4

Browse files
committed
fix tests
1 parent effc041 commit 826cde4

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

dask-xfails.txt

+3
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ array_api_tests/test_data_type_functions.py::test_finfo[float32]
3737
# (I think the test is not forcing the op to be computed?)
3838
array_api_tests/test_creation_functions.py::test_linspace
3939

40+
# out.shape=(2,) but should be (1,)
41+
array_api_tests/test_indexing_functions.py::test_take
42+
4043
# out=-0, but should be +0
4144
array_api_tests/test_special_cases.py::test_binary[__pow__(x1_i is -0 and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +0]
4245
array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -0 and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +0]

tests/test_common.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,14 @@ def test_to_device_host(library):
6464

6565
@pytest.mark.parametrize("target_library,func", is_functions.items())
6666
@pytest.mark.parametrize("source_library", is_functions.keys())
67-
def test_asarray(source_library, target_library, func):
67+
def test_asarray(source_library, target_library, func, request):
68+
if source_library == "dask.array" and target_library == "torch":
69+
# Allow rest of test to execute instead of immediately xfailing
70+
# xref https://github.com/pandas-dev/pandas/issues/38902
71+
72+
# TODO: remove xfail once
73+
# https://github.com/dask/dask/issues/8260 is resolved
74+
request.node.add_marker(pytest.mark.xfail(reason="Bug in dask raising error on conversion"))
6875
src_lib = import_(source_library, wrapper=True)
6976
tgt_lib = import_(target_library, wrapper=True)
7077
is_tgt_type = globals()[func]

0 commit comments

Comments
 (0)