refactor(dapi-client): replace CanRetry.is_node_failure with !CanRetry.can_retry()

Author: lklimek

packages/rs-dapi-client/src/dapi_client.rs

@@ -39,12 +39,12 @@ pub enum DapiClientError<TE: Mockable> {
 }
 
 impl<TE: CanRetry + Mockable> CanRetry for DapiClientError<TE> {
-    fn is_node_failure(&self) -> bool {
+    fn can_retry(&self) -> bool {
         use DapiClientError::*;
         match self {
-            NoAvailableAddresses => false,
-            Transport(transport_error, _) => transport_error.is_node_failure(),
-            AddressList(_) => false,
+            NoAvailableAddresses => true,
+            Transport(transport_error, _) => transport_error.can_retry(),
+            AddressList(_) => true,
             #[cfg(feature = "mocks")]
             Mock(_) => false,
         }
@@ -222,7 +222,7 @@ impl DapiRequestExecutor for DapiClient {
                         tracing::trace!(?response, "received {} response", response_name);
                     }
                     Err(error) => {
-                        if error.is_node_failure() {
+                        if !error.can_retry() {
                             if applied_settings.ban_failed_address {
                                 let mut address_list = self
                                     .address_list
@@ -253,12 +253,12 @@ impl DapiRequestExecutor for DapiClient {
                     duration.as_secs_f32()
                 )
             })
-            .when(|e| e.is_node_failure())
+            .when(|e| !e.can_retry())
             .instrument(tracing::info_span!("request routine"))
             .await;
 
         if let Err(error) = &result {
-            if error.is_node_failure() {
+            if !error.can_retry() {
                 tracing::error!(?error, "request failed");
             }
         }

packages/rs-dapi-client/src/lib.rs

@@ -73,6 +73,14 @@ impl<T: transport::TransportRequest + Send> DapiRequest for T {
 /// Allows to flag the transport error variant how tolerant we are of it and whether we can
 /// try to do a request again.
 pub trait CanRetry {
+    /// Returns true if the operation can be retried safely, false means it's unspecified
+    fn can_retry(&self) -> bool;
+
     /// Get boolean flag that indicates if the error is retryable.
-    fn is_node_failure(&self) -> bool;
+    ///
+    /// Depreacted in favor of [CanRetry::can_retry].
+    #[deprecated = "Use !can_retry() instead"]
+    fn is_node_failure(&self) -> bool {
+        !self.can_retry()
+    }
 }

packages/rs-dapi-client/src/transport/grpc.rs

@@ -75,11 +75,11 @@ impl TransportClient for CoreGrpcClient {
 }
 
 impl CanRetry for dapi_grpc::tonic::Status {
-    fn is_node_failure(&self) -> bool {
+    fn can_retry(&self) -> bool {
         let code = self.code();
 
         use dapi_grpc::tonic::Code::*;
-        matches!(
+        !matches!(
             code,
             Ok | DataLoss
                 | Cancelled