Merge #7249: refactor: remove BlockAssembler from friends of CChainstateHelper

a184703 refactor: remove BlockAssembler from friends of CChainstateHelper (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  CHainstateHelper and BlockAssembler no need to be friends

  ## What was done?
  See commit, changes are trivial

  ## How Has This Been Tested?
  Run unit & functional tests

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

Top commit has no ACKs.

Tree-SHA512: cd401f43e0f1d8c936d6bc827d3bbefd001fe13238f266b44d6eba98bbd631e6c1b7fb917a5df6c7e32c54286747a439fdd0b017fa79fc3514c9df17b2149734

Author: PastaPastaPasta

src/evo/chainhelper.h

@@ -34,19 +34,13 @@ class CQuorumBlockProcessor;
 class CQuorumManager;
 class CQuorumSnapshotManager;
 } // namespace llmq
-namespace node {
-class BlockAssembler;
-} // namespace node
-
 class CChainstateHelper
 {
-    friend class node::BlockAssembler;
-
 private:
     llmq::CInstantSendManager& isman;
-    const std::unique_ptr<CCreditPoolManager> credit_pool_manager;
 
 public:
+    const std::unique_ptr<CCreditPoolManager> credit_pool_manager;
     const chainlock::Chainlocks& m_chainlocks;
     const std::unique_ptr<CMNHFManager> ehf_manager;
     const std::unique_ptr<CMNPaymentsProcessor> mn_payments;