[primary constructors] non_constant_identifier_names support

Fixes: #62016

Bug: #62016
Change-Id: I8f397d99ba7a6a6ac8d3d3abb65579c97be5ed0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/462743
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/lib/src/rules/non_constant_identifier_names.dart

@@ -40,6 +40,7 @@ class NonConstantIdentifierNames extends AnalysisRule {
     registry.addFunctionDeclaration(this, visitor);
     registry.addMethodDeclaration(this, visitor);
     registry.addPatternField(this, visitor);
+    registry.addPrimaryConstructorName(this, visitor);
     registry.addRecordLiteral(this, visitor);
     registry.addRecordTypeAnnotation(this, visitor);
     registry.addVariableDeclaration(this, visitor);
@@ -130,6 +131,11 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 
+  @override
+  void visitPrimaryConstructorName(PrimaryConstructorName node) {
+    checkIdentifier(node.name, underscoresOk: true);
+  }
+
   @override
   void visitRecordLiteral(RecordLiteral node) {
     for (var fieldExpression in node.fields) {

pkg/linter/test/rules/non_constant_identifier_names_test.dart

@@ -802,6 +802,27 @@ class C {
     );
   }
 
+  test_primaryConstructor_lowerCase() async {
+    await assertNoDiagnostics(r'''
+class C.named();
+''');
+  }
+
+  test_primaryConstructor_underscores() async {
+    await assertNoDiagnostics(r'''
+class C.___();
+    ''');
+  }
+
+  test_primaryConstructor_upperCase() async {
+    await assertDiagnostics(
+      r'''
+class C.Named();
+''',
+      [lint(8, 5)],
+    );
+  }
+
   test_topLevelFunction() async {
     await assertDiagnostics(
       r'''