Skip to content

Commit 29b291f

Browse files
stereotype441Commit Queue
authored andcommitted
[messages] Fix error_fix_status.yaml.
Adds missing `status` entries to the analysis server's `error_fix_status.yaml` file. The reason these were missing was because currently, the only validation logic that checks that `status` entries are present is in `pkg/linter/tool/machine.dart` (the `readFixStatusMap` function), and it ignores entries that don't start with the class name prefix `LintCode.`. This paves the way for a follow-up CL that will remove the class name prefixes from `error_fix_status.yaml` entirely (as part of a larger effort to remove those classes from the codebase). Note that the validation logic in `readFixStatusMap` is not really very robust; it only checks that the `status` entries are strings. In a follow-up CL I will add a more thorough check. Change-Id: I6a6a69644f7cc07162f5614c87149d6e72b99d23 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/462700 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent fef8cbf commit 29b291f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,13 +1110,15 @@ CompileTimeErrorCode.MIXIN_APPLICATION_NOT_IMPLEMENTED_INTERFACE:
11101110
CompileTimeErrorCode.MIXIN_CLASS_DECLARATION_EXTENDS_NOT_OBJECT:
11111111
status: hasFix
11121112
CompileTimeErrorCode.MIXIN_CLASS_DECLARES_CONSTRUCTOR:
1113+
status: needsFix
11131114
notes: |-
11141115
Remove the constructor.
11151116
CompileTimeErrorCode.MIXIN_DEFERRED_CLASS:
11161117
status: needsFix
11171118
notes: |-
11181119
Remove the `deferred` keyword from the import.
11191120
CompileTimeErrorCode.MIXIN_INHERITS_FROM_NOT_OBJECT:
1121+
status: needsFix
11201122
notes: |-
11211123
Remove the extends clause.
11221124
CompileTimeErrorCode.MIXIN_INSTANTIATE:

0 commit comments

Comments
 (0)