[ffigen] Remove an old TODO that filtered certain methods from package:objective_c (#2335)

Author: liamappelbe

pkgs/ffigen/lib/src/code_generator/objc_built_in_types.dart

@@ -33,10 +33,12 @@ const objCBuiltInInterfaces = {
   'NSNumber': 'NSNumber',
   'NSObject': 'NSObject',
   'NSOutputStream': 'NSOutputStream',
+  'NSOrderedCollectionChange': 'NSOrderedCollectionChange',
   'NSOrderedCollectionDifference': 'NSOrderedCollectionDifference',
   'NSOrderedSet': 'NSOrderedSet',
   'NSPort': 'NSPort',
   'NSPortMessage': 'NSPortMessage',
+  'NSProgress': 'NSProgress',
   'NSRunLoop': 'NSRunLoop',
   'NSSet': 'NSSet',
   'NSStream': 'NSStream',
@@ -65,6 +67,7 @@ const objCBuiltInCompounds = {
 const objCBuiltInEnums = {
   'NSAppleEventSendOptions',
   'NSBinarySearchingOptions',
+  'NSCollectionChangeType',
   'NSComparisonResult',
   'NSDataBase64DecodingOptions',
   'NSDataBase64EncodingOptions',

pkgs/ffigen/lib/src/code_generator/objc_methods.dart

@@ -30,14 +30,12 @@ mixin ObjCMethods {
 
   void addMethod(ObjCMethod? method) {
     if (method == null) return;
-    if (_shouldIncludeMethod(method)) {
-      final oldMethod = getSimilarMethod(method);
-      if (oldMethod != null) {
-        _methods[method.key] = _maybeReplaceMethod(oldMethod, method);
-      } else {
-        _methods[method.key] = method;
-        _order.add(method.key);
-      }
+    final oldMethod = getSimilarMethod(method);
+    if (oldMethod != null) {
+      _methods[method.key] = _maybeReplaceMethod(oldMethod, method);
+    } else {
+      _methods[method.key] = method;
+      _order.add(method.key);
     }
   }
 
@@ -89,20 +87,6 @@ mixin ObjCMethods {
     return newMethod;
   }
 
-  bool _shouldIncludeMethod(ObjCMethod method) =>
-      method.childTypes.every((Type t) {
-        t = t.typealiasType.baseType;
-
-        // Ignore methods with block args or rets when we're generating in
-        // package:objective_c.
-        // TODO(https://github.com/dart-lang/native/issues/1180): Remove this.
-        if (builtInFunctions.generateForPackageObjectiveC && t is ObjCBlock) {
-          return false;
-        }
-
-        return true;
-      });
-
   UniqueNamer createMethodRenamer(Writer w) =>
       UniqueNamer(parent: w.topLevelUniqueNamer)
         ..markAllUsed([

pkgs/ffigen/pubspec.yaml

@@ -40,7 +40,7 @@ dev_dependencies:
   dart_flutter_team_lints: ^2.0.0
   json_schema: ^5.1.1
   leak_tracker: ^10.0.7
-  objective_c: ^8.0.0
+  objective_c: ^8.1.0
   test: ^1.16.2
 
 dependency_overrides:

pkgs/objective_c/ffigen_objc.yaml

@@ -53,10 +53,12 @@ objc-interfaces:
     - NSNumber
     - NSObject
     - NSOutputStream
+    - NSOrderedCollectionChange
     - NSOrderedCollectionDifference
     - NSOrderedSet
     - NSPort
     - NSPortMessage
+    - NSProgress
     - NSRunLoop
     - NSSet
     - NSStream
@@ -124,6 +126,7 @@ enums:
   include:
     - NSAppleEventSendOptions
     - NSBinarySearchingOptions
+    - NSCollectionChangeType
     - NSComparisonResult
     - NSDataBase64DecodingOptions
     - NSDataBase64EncodingOptions

pkgs/objective_c/lib/objective_c.dart

@@ -28,7 +28,7 @@ export 'src/ns_input_stream.dart';
 export 'src/ns_mutable_data.dart';
 export 'src/ns_number.dart';
 export 'src/ns_string.dart';
-export 'src/objective_c_bindings_generated.dart';
+export 'src/objective_c_bindings_exported.dart';
 export 'src/os_version.dart';
 export 'src/protocol_builder.dart';
 export 'src/selector.dart';

pkgs/objective_c/lib/src/objective_c_bindings_exported.dart

@@ -0,0 +1,118 @@
+// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Generated by package:objective_c's tool/generate_code.dart.
+
+export 'objective_c_bindings_generated.dart'
+    show
+        AEDesc,
+        CFRunLoop,
+        CFString,
+        CGPoint,
+        CGRect,
+        CGSize,
+        DartProtocol,
+        DartProtocolBuilder,
+        NSAppleEventSendOptions,
+        NSArray,
+        NSBinarySearchingOptions,
+        NSCharacterSet,
+        NSCoder,
+        NSCoding,
+        NSCollectionChangeType,
+        NSComparisonResult,
+        NSCopying,
+        NSData,
+        NSDataBase64DecodingOptions,
+        NSDataBase64EncodingOptions,
+        NSDataCompressionAlgorithm,
+        NSDataCreation,
+        NSDataReadingOptions,
+        NSDataSearchOptions,
+        NSDataWritingOptions,
+        NSDate,
+        NSDecodingFailurePolicy,
+        NSDictionary,
+        NSEdgeInsets,
+        NSEnumerationOptions,
+        NSEnumerator,
+        NSError,
+        NSExtendedArray,
+        NSExtendedData,
+        NSExtendedDate,
+        NSExtendedDictionary,
+        NSExtendedEnumerator,
+        NSExtendedMutableArray,
+        NSExtendedMutableData,
+        NSExtendedMutableDictionary,
+        NSExtendedMutableOrderedSet,
+        NSExtendedMutableSet,
+        NSExtendedOrderedSet,
+        NSExtendedSet,
+        NSFastEnumeration,
+        NSFastEnumerationState,
+        NSIndexSet,
+        NSInputStream,
+        NSInvocation,
+        NSItemProvider,
+        NSItemProviderFileOptions,
+        NSItemProviderReading,
+        NSItemProviderRepresentationVisibility,
+        NSItemProviderWriting,
+        NSKeyValueChange,
+        NSKeyValueObservingOptions,
+        NSKeyValueSetMutationKind,
+        NSLinguisticTaggerOptions,
+        NSLocale,
+        NSLocaleLanguageDirection,
+        NSMethodSignature,
+        NSMutableArray,
+        NSMutableCopying,
+        NSMutableData,
+        NSMutableDictionary,
+        NSMutableIndexSet,
+        NSMutableOrderedSet,
+        NSMutableSet,
+        NSMutableString,
+        NSNotification,
+        NSNumber,
+        NSNumberCreation,
+        NSNumberIsFloat,
+        NSObject,
+        NSObjectProtocol,
+        NSOrderedCollectionChange,
+        NSOrderedCollectionDifference,
+        NSOrderedCollectionDifferenceCalculationOptions,
+        NSOrderedSet,
+        NSOutputStream,
+        NSPort,
+        NSPortDelegate,
+        NSPortMessage,
+        NSProgress,
+        NSPropertyListFormat,
+        NSQualityOfService,
+        NSRange,
+        NSRunLoop,
+        NSSecureCoding,
+        NSSet,
+        NSSortOptions,
+        NSStream,
+        NSStreamDelegate,
+        NSStreamEvent,
+        NSStreamStatus,
+        NSString,
+        NSStringCompareOptions,
+        NSStringEncodingConversionOptions,
+        NSStringEnumerationOptions,
+        NSStringExtensionMethods,
+        NSTimer,
+        NSURL,
+        NSURLBookmarkCreationOptions,
+        NSURLBookmarkResolutionOptions,
+        NSURLHandle,
+        NSURLHandleStatus,
+        NSValue,
+        NSZone,
+        OpaqueAEDataStorageType,
+        Protocol;